DEV Community

TJ Johnson
TJ Johnson

Posted on

1

How do you go about constructive criticism of code?

Top comments (2)

Collapse
 
alainvanhout profile image
Alain Van Hout • Edited

Three simple ways to phrase these things is:

  • As a question: What if we ...? How about changing this to ...? Might X also work here?
  • As a further improvement: This approach will work even better if we ... We could also do X here, so that
  • Say it from the point of the team: all the use of 'we' in the previous items

Combining the three generally works best in my own experience.

Collapse
 
masterroshan profile image
TJ Johnson

There's a camp that you should not give unsolicited criticism. But sometimes problems that go unchecked can end up being your responsibility. How do you reconcile?

Billboard image

Create up to 10 Postgres Databases on Neon's free plan.

If you're starting a new project, Neon has got your databases covered. No credit cards. No trials. No getting in your way.

Try Neon for Free →