DEV Community

Cover image for Code Smell 62 - Flag Variables

Code Smell 62 - Flag Variables

Maxi Contieri on February 08, 2021

Flags indicate what happened. Unless their name is too generic. Problems Readability Maintainability Coupling Solutions ...
Read full post
Collapse
 
michaelcurrin profile image
Michael Currin •

You suggested to restrict usage but didn't say how or provide and example.

Can I provide an alternative without the flag? Which is shorter and more readable.

while(true) {
  $elementSatisfies = doSomething();
  if (!$elementSatisfies) {
    break;
  }
}
Enter fullscreen mode Exit fullscreen mode

Or even

while(doSomething()) {
  pass
}
Enter fullscreen mode Exit fullscreen mode