Skip to content

DEV Community

Discussion on: Code Smell 146 - Getter Comments

View post

Replies for: Any reason why you changed price to _price in your "Right" code version? Some people like to prefix private variables with an underscore but yours...

Maxi Contieri • Jul 7 '22

My code is generated by Copilot.
It changed it.
I am fine with both conventions

Julien Dephix • Jul 7 '22

I see. I would have marked it as private in the “wrong” version to begin with. Otherwise having a getter on a public property is unnecessary.

Maxi Contieri • Jul 8 '22

you are right, I'll change it to private

Julien Dephix • Jul 8 '22

Change it in the "Right" version and it's all good!