DEV Community

loading...

Discussion on: How to have better code reviews & tips for junior developers

Collapse
mfarajewicz profile image
Mirosław Farajewicz

Good and important suggestions taken together.

I'm extremely surprised that there is little articles about code-reviewing culture. Not only on dev.to but generally on the internet.

Collapse
arey_abhishek profile image
Abhishek Nayak

That's true. I'd like to write a post about code reviews. What would you like it to include?

Collapse
mfarajewicz profile image
Mirosław Farajewicz

It's hard to decide as it's pretty personal. Many companies have slightly different standards. But I would say

  • the process itself: how many people in the team do one review, pre/post commit review
  • way of discussion - written / spoken. Longer elaboration (eg. "this code should be extracted to separate method XYZ and the duplicated piece from ABC should also be replaced) or short (eg. "duplication") hints
  • best tools, except the obvious choice of GH/GL/BB pull requests
  • things you should check or you should ignore ( code styling if some kind of static analysis bound to repo)
  • argues solving