Code reviews.
You know how important they are.
They are one of the pillars of getting reliable code out there.
Yet, it’s one of those ...
Some comments have been hidden by the post's author - find out more
For further actions, you may consider blocking this person and/or reporting abuse
Thank you for this!
Feedback is a gift. The sole reason is to improve the quality of the code base. The more errors you point out in your code, the better your code will be.
Exactly! And it's not limited to errors either. General code quality, abstractions, etc. done well can benefit everyone working on a codebase!
Yep :)
Great read @jayantbh ! I have learned a lot from Code Reviews and its was solely because of the well structured the comments you left on my PRs followed by the reasoning for changes. The point where people optimise for review time instead of review cycles was bang on as it ends up wasting more time in totality.
Nice article! Should code reviews be done at the start of the developer's day or at the end?
Honestly there's no silver bullet answer to this, and neither should there be.
Someone might like doing this at the start, or at the end. Before, or after lunch. Or at a fixed time every day when they aren't likely to get any meetings.
Someone with more discipline and focus than me might even deal with reviews in between other work, as a break!
This one is quite extensive, Jayant.
Thank you Aravind! Glad you liked it!
Super informative article
Quite an insightful piece Jayant!
Nice Article. It describes a lot of problems I've seen many times with reviews in the past. Middleware looks nice, but for me, it's a bit too expensive. But we don't need to discuss this here as opinions about prices definitely will differ here :D
Amazing, Amazing, Amazing!!! You guys are metrics-driven evangelists like us at Litlyx.
Share some love on our Github Open-Source Repo for Easy Analytics with 1 line of code!
That is an awesome project! Glad you liked the post, and thanks for sharing your project
One observation: the further "upstream" you move the difficult decisions, the more effort (time/energy) you will save "downstream". In this case, being judicious when you hire / bring people onto your team will go a long way towards minimizing wasteful PR/MR cycles.
I partly agree, because yes, if you optimize for people who can collaborate really well, you'll likely deliver faster.
But despite your best efforts, interviews can be an inherently flawed process. You might find people who are great collaborators, but may not be great at more technical work.
It might be better served by training people and having processes in place that are enforced with care. Because hiring is already very hard. :(
thats a really detailed one. Nice work.
Glad you liked it!
My fav application at this moment