DEV Community

Discussion on: The Good Place - A GitHub Action 🍤

Collapse
 
moopet profile image
Ben Sinclair

I haven't run it, but will this run a cropper with the Scunthorpe problem?

Without word boundaries in the regular expression, it'll cause strife with Cockney Rhyming Slang generators.

Collapse
 
jayehernandez profile image
Jaye Hernandez

Only knew about this problem as you raised it! I’ll be testing it out to see.

Collapse
 
jayehernandez profile image
Jaye Hernandez

Just deployed a fix for the Scunthorpe problem. I've changed the regular expression to account for word boundaries.

Now words like classic won't turn into clashic (since ass -> ash). Thanks for bringing this up!

Thread Thread
 
moopet profile image
Ben Sinclair

"Clashic" - Sean Connery.