DEV Community

Discussion on: What made you look at a project and submit a PR? Or Not?

Collapse
 
moopet profile image
Ben Sinclair • Edited

My most recent PR was to a project I was using which displayed PHP warnings under certain circumstances. It wasn't because the input was unexpected, it was because the code was handling it incorrectly. It wasn't a visible error most of the time. I could have raised an issue, but instead I just went ahead and fixed the two lines I felt were at fault and gave a brief explanation of what I'd done in the PR comment.

This took about 15 minutes and didn't inconvenience me in any way. It was such a minor issue compared to others that if I'd ticketed it it would probably never get read. As it happens, it's not been read as a PR either, but there's only so much you can do, right?

My most recent non-PR was something I fixed locally with a patch to a contrib module for something, but I selfishly didn't want to give my solution back to the community because I don't want to encourage people to use that software. I know that other people are perfectly capable of making up their own minds about whether to use something, but I also don't want to be part of promoting what I see is a problematic platform. So while the idea crossed my mind and it wouldn't have taken long, I didn't get involved.