Overview
The objective of the second lab was to contribute to the repository of one of my classmates with my implementation of the markdown file processing.
Selecting the repository to contribute in
I decided to partner up with Taiomoor again and contribute to his repo siteit because he uses the javascript, which I am familiar with and his code style is decent.
Issue
The first step was to create an issue in his GitHub repository to let him know that I will work on it and describe what I plan to accomplish.
Implementation
The implementation of PR didn't take me a lot of time I performed the following changes in it:
- made tool proccess not only '.txt' extension files, but also '.md'
- made tool handle the bold text and italic text markdown syntax and translate it into the correct HTML form with respectful HTML syntax -update readme.md with the description of markdown files handling support
Working with feedback
After I craeted the PR Taimoor provided me some comments about my updates and showed some cases where my updates might not work as expected. I followed his advice and made proper update in order to make tool work as expected.
Top comments (0)