DEV Community

loading...

Discussion on: Developers Ego

Collapse
nina_rallies profile image
Nina Rallies

I have a colleague who’s extremely good at reviews. He’ll leave comments on PRs you’re pretty sure have no issues. His comments are mostly on typos, better names, or a paragraph long comment on why this one line of code should be broken down into two for readability. At first I’d try to get my PRs approved by others before he got to them. I admit , I was silly! Later on I figured he’s offering me more than I could ask for. His comments come from years of experience; he makes our code base readable, and it’s because of his efforts that our unboarding process is quick. I’ve come to appreciate his efforts and time. I’m not in a hurry to push PRs ASAP anymore. Shoutout to all great reviewers and my incredibly kind colleague... you are amazing!

Collapse
0xarjunshetty profile image
Arjun Shetty Author

I second that!
Even I was on the same boat as you were at my early dev days. You surely are on the right path.
All those great reviewers they manage to keep peace. They know the pain of being in Production Incidents burning the midnight oil. Its no fun.