DEV Community

Discussion on: Share your experience with feelings of embarrassment during code reviews

Collapse
 
okeeffed profile image
Dennis O'Keeffe

Two days ago we had a flaky test fail from timezone issues that I threw a quick fix for (required the test to expect if it was July 1st vs Jan 1st based on current date but the expectation variable was flaky).

Then yesterday I had to code review another PR on that same file since my quick fix failed a day later because it set the variable to July 2nd 🤦 🤦 🤦 WHOOPS