I was reviewing candidate's tests for some time and I agree in most of the things. About GitHub, some companies may require to have a zip file sent instead.
For me, as a reviewer, the most important thing before starting to look at the code, is to have a deliverable that I can compile myself. After that, I focus more on clean and readable code.
One time we had one person who sent us the test solution in a PDF!!!!
For sure sending the test as a link to a git repo gives extra points!
And that was also our reaction when we saw the PDF! Like seriously, how do you expect your code to be reviewed?
And that makes me think that being a good software engineer is definitely not only about coding. So a candidate's test deliverable should go in the same direction. I much prefer a clean and well structured project with some flaws or minor bugs than a perfect solution where only the dev who wrote it understand how it works.
Yeah, our process is more about to see if the candidate fits our team and how he thinks.
It's not about the perfect code because there is no such thing as perfect code.
Coding itself is just one thing a good software engineer has to be good in there are so much more. People really tend to forget soft skills a lot but they are as important as good code.
For further actions, you may consider blocking this person and/or reporting abuse
We're a place where coders share, stay up-to-date and grow their careers.
I was reviewing candidate's tests for some time and I agree in most of the things. About GitHub, some companies may require to have a zip file sent instead.
For me, as a reviewer, the most important thing before starting to look at the code, is to have a deliverable that I can compile myself. After that, I focus more on clean and readable code.
One time we had one person who sent us the test solution in a PDF!!!!
Yes, your right, not every company wants that but if they don't want that they should specify it and as a bonus, GitHub now has private free repos!
In a PDF? What? Why? How? What was he/she thinking?
For sure sending the test as a link to a git repo gives extra points!
And that was also our reaction when we saw the PDF! Like seriously, how do you expect your code to be reviewed?
And that makes me think that being a good software engineer is definitely not only about coding. So a candidate's test deliverable should go in the same direction. I much prefer a clean and well structured project with some flaws or minor bugs than a perfect solution where only the dev who wrote it understand how it works.
Yeah, our process is more about to see if the candidate fits our team and how he thinks.
It's not about the perfect code because there is no such thing as perfect code.
Coding itself is just one thing a good software engineer has to be good in there are so much more. People really tend to forget soft skills a lot but they are as important as good code.