Good work though I notice a slight bug if you click the same 'dot' twice and the screen goes blank. I think you need to check whether the same button has been clicked and do nothing.:)
Just checked on PC and a Mac in Firefox and Chrome on both (and Safari and ios on mobile) and it still doesn't work properly. It's not really usable in its current state and I suggest you test again.
Just click the current dot nav again (or another dot twice) and you will see that the displayed image scales to zero leaving a blank screen - that is not a nice effect. You then have to click again to bring it back.
Hello, I have implemented this check with the following code
// It helps to move the dot, it take "index"
//as parameter and update the slideIndex
function moveDot(index) {
slideIndex = index;
const activeSlide = slides.querySelector("[data-active]");
const nextPrevSlide = slides.children[slideIndex - 1];
if(activeSlide !== nextPrevSlide)
updateImageAndDot();
}
Sorry for my english
For further actions, you may consider blocking this person and/or reporting abuse
We're a place where coders share, stay up-to-date and grow their careers.
Good work though I notice a slight bug if you click the same 'dot' twice and the screen goes blank. I think you need to check whether the same button has been clicked and do nothing.:)
I don't face this problem, but I'll look into it, if I found any. Thanks for the feedback. 👍
If it helps it happens to me in both Chrome and Firefox.
Screenshot attached.
Just checked on PC and a Mac in Firefox and Chrome on both (and Safari and ios on mobile) and it still doesn't work properly. It's not really usable in its current state and I suggest you test again.
Just click the current dot nav again (or another dot twice) and you will see that the displayed image scales to zero leaving a blank screen - that is not a nice effect. You then have to click again to bring it back.
The problem is evident on all browsers.
Oh I see, I'll fix that ASAP. Thanks mate.
Hello, I have implemented this check with the following code
Sorry for my english