I like the idea of the LOGAF scale, where we can easily indicate if suggestions to PR review or other feedback is given in 'levels of give-a-f*ck'. A scale like this helps collaborators prioritize and contextualize your feedback quickly in a way that's pretty straightforward.
While I love the raw LOGAF model, I do sometimes hesitate to share this philosophy with everyone at my company based on varying levels of comfort with profanity. Instead, I took the time just to indicate my own low/medium/high 'level of caring' that I can share on PR reviews. I also took the time to briefly spell out what I expect from each level. Now in PRs I can include a 'LOGAF level' link and move on.
Below is my basic scale of 3 levels, the description of each, and the link I'd include in each comment.
Low
A this level I usually just noticed something that had a slight code smell. I may spot things that are tangential to your change or just things I 'noticed' when reviewing.
You can self-resolve these comments in GitHub without a comment.
[🟢 low](https://dev.to/robotsquidward/create-your-own-logaf-scale-for-pull-request-reviews-504o/#low)
Medium
At this level I feel changes should be made but can be convinced with a good reason, a follow up story/documentation/etc. that captures the changes in future work or clarification.
You can self-resolve these comments in GitHub with a comment.
[🟡 medium](https://dev.to/robotsquidward/create-your-own-logaf-scale-for-pull-request-reviews-504o/#medium)
High
At this level I feel like changes need to be made before this PR is merged. In exceptional cases, follow up stories & documentation may resolve these concerns, but they would usually require a conversation with me or some other SME.
Do not self-resolve these comments in GitHub. Make changes / leave comments and allow me to resolve them before merging.
[🔴 high](https://dev.to/robotsquidward/create-your-own-logaf-scale-for-pull-request-reviews-504o/#high)
If you decide to implement your own LOGAF scale for your PR reviews let me know on Mastodon @aj on androiddev.social.
Top comments (0)