Discussion on: React.js Interview - technical submission and detailed feedback

View post

Jeferson 'Shin' Leite Borges • Jul 26 '22 • Edited

Your code is a little bit messy.
Use this to learn, improve the quality.

Let me add some details on this,

On this folder you have files using camel case and kebab case. I don't care which one is used, but be consistent.
This file is just an exporter. In this case, this file should follow the same rule.
This is a little bit over complex without returning value to the project.

There is extra stuff,
For a regular developer this is not expected, but for a senior position, this type of care is expected, in special if you are going to mentor other developers.

alvinpeter9 • Jul 26 '22

Thanks, I have learnt from your explanation as well

Rajesh Royal • Jul 27 '22

⚫ Second Point.
The default exporter of containers is created because there can be multiple exports of containers. [ex. - HOC for error boundary, HOC for Auth Provider and etc.] That's why it have only exports. But in case of a particular page there will be only page itself to be exported.

⚫ Third Point.
I accept it looks a little bit complex for just 2 routes, I could have just added two simple routes. But keeping the scalling of routes in mind I implemented it this way so It will be more easy to add childrens to the routes anytime in future.

Your feedback is really helpfull, what idea I get from the company feedback is that I should be doing what needed and in simply ways, instead of thinking the future prespectives. [deliver what needed 😄]

Thanks @shinspiegel