DEV Community πŸ‘©β€πŸ’»πŸ‘¨β€πŸ’»

DEV Community πŸ‘©β€πŸ’»πŸ‘¨β€πŸ’» is a community of 968,873 amazing developers

We're a place where coders share, stay up-to-date and grow their careers.

Create account Log in
Tuan Thanh Tan
Tuan Thanh Tan

Posted on

My first PR in hacktoberfest 2021

Hello every, my name is Dustin. I'd like to talk about my experience of solving very first and simple issues on github that are labelled as hacktoberfest 2021.

Reasons

The reason behind why I decided to contribute to open sources project is because I will learn a bunch of new things and coding styles.

First pull request

My very first pull request was pretty simple and short in terms of coding but reading the code and finding where it is to fix was difficult enough.

The project can be found here
My pull request can be found here

Detail

Interesting enough though, when I understood the issue clearly and started to fork the project, I got into a problem where I cannot clone the project locally. You can find the issue here but it turned out that there a little space after a file name. A project maintainer resolved it immediately so that I could clone the project.

The issue was actually about a url link. There's a few buttons that allow users to copy, or share the post on their social platforms. But the link was assigned to a static url that points straight to the main landing page. So what I did was that I pull the current url off of window.location.href and set it to the URL. Every worked just fine. The process of fixing code was quite easy but I had to go through a lot of files and folders to find the issue because this project is quite huge.

const URL = 'https://seismic-risc.now.sh';
Enter fullscreen mode Exit fullscreen mode

to

const URL = window.location.href;
Enter fullscreen mode Exit fullscreen mode

Top comments (0)

πŸ‘‹ Hey, my name is Noah and I’m the one who set up this ad. My job is to get you to join DEV, so if you fancy doing me a favor, I’d love for you to create an account.

If you found DEV from searching around, here are a couple of our most popular articles on DEV: