loading...

Discussion on: Tell me an unpopular software opinion

Collapse
aaronktberry profile image
Aaron Berry

I agree. I always found it daunting looking at a PR with 40+ files changed without even knowing what the PR should be doing. In the end, it always seemed to just end up being more efficient sitting down with the owner of the PR and them walking through what changed and reviewing it with them.

Oh and also actually getting the person to RUN the code to see it actually is doing what they expect it to do rather than assuming its working correctly.

Collapse
jessekphillips profile image
Jesse Phillips

Plug

Or a little more specific

Code review should include reviewing the history, it is such an important log, those in person conversations need written down for the poor maintenance folks when both of you aren't available.

Collapse
patryktech profile image
Patryk

I always found it daunting looking at a PR with 40+ files changed without even knowing what the PR should be doing.

Do you even CI, bro? :D

I'd consider looking into Continuous Integration. Smaller commits are oftentimes safer commits.