DEV Community

anshul137
anshul137

Posted on

Release 0.3: Internal Code Reviews

Code Review

Code Review, also known as Peer Code Review, is the act of consciously and systematically convening with oneโ€™s fellow programmers to check each otherโ€™s code for mistakes and has been repeatedly shown to accelerate and streamline the process of software development like few other practices can.

We were asked to work on two code reviews for this assignment.

First Review

First review

In this review i believe theOptimal font sizes for desktop for the button should be around 16px to 18px for legibility (or 1.6rem to 1.8rem using our sizing rules mentioned above). If you can afford to go a bit larger, then even 21px can be pleasant to read.

There are no exact rules for font sizing, but there are some generally good practices to think about when designing.

Second Review

Second review

I have requested to update the README.md.

Top comments (0)