DEV Community

Cover image for Effective Java —Chapters 6 to 9
Ashkan Entezari
Ashkan Entezari

Posted on

Effective Java —Chapters 6 to 9


This is part 2 of my summary of "Effective Java". For the first part of this summary (chapters 2 to 5) you can refer to this post.

A reminder that *Effective Java is a reference-like book and I tried to have this summary as a quick point of reference. I summarized each item and included my take on it. If you found issues or have suggestions to make them easier and more understandable, please let me know.

6 Enums and Annotations

Item 34

  • Use enums instead of int constants
  • When we have an enumerated type whose values are a fixed set of constants we should use enum. Bad alternatives are constant strings or ints like this:
  // bad
  public static final int APPLE_FUJI = 0;
  public static final int APPLE_PIPPIN = 1;

  public static final int ORANGE_NAVEL = 0;
  public static final int ORANGE_BLOOD = 1;

instead we can use something like this:

  public enum Apple { FUJI, PIPPIN, GRANNY_SMITH }
  public enum Orange { NAVEL, BLOOD, TEMPLE }
  • this item also talks about various disadvantages of using constant ints or strings. For example in above example int values are used for both orange and apple types, later we can do math operations with these ints or can potentially compare these ints which is mathematically allowed but we are basically comparing apples to oranges! They are also verbose (long prefixes before each constant —APPLE_)
  • enums are designed for this and other than simple example above (which is what we need most of the times) we can make them more advanced with extra functionalities:
public enum Planet {
    MERCURY(3.302e+23, 2.439e5),
    VENUS(4.859e+24, 6.052e6),
    EARTH(5.975e+24, 6.378e6),

    private final double mass;
    private final double radius;
    private final double surfaceGravity;

    // constructor
    Planet(double mass, double radius) {
        this.mass = mass;
        this.radius = radius;
        surfaceGravity = 6.6e-11 * mass / (radius*radius);

    public double mass() {return mass;}
    public double radius() {return radius;}
    public double surfaceGravity() {return surfaceGravity;}

    public double surfaceWeight(double mass) {
        return mass * surfaceGravity;
  • in the above code sample we are associating data with enum constants (mass, radius,..) and to do that we should add a constructor. we've also added a shared functionality to easily calculate the surface weight for each constant. Look at these sample usages of the above enum:
double earthWeight = 158; // or read from input
double mass = earthWeight / Planet.EARTH.surfaceGravity();


for (Planet planet : Planet.values()) {
    System.out.println("Weight on " + planet + " is " + planet.surfaceWeight(mass));
  • note that all enums have static values() that returns an array of their values. they also have a default toString() which returns the declared name of each enum value. We can override this if we want.
  • If enums are only needed in a class we should define them as a member class of that class, but if they are helpful in other places we should declare them as a top-level class.
  • in Planet enum example we had a shared functionality (surfaceWeight()) that was similar for all of its constants. If we want a method that behaves different for each constant, best approach is to define an abstract method and implement it like this:
public enum Operation {
    PLUS("+") {public double apply(double x, double y){return x + y;} },
    MINUS("-") {public double apply(double x, double y){return x - y;} },
    TIMES("*") {public double apply(double x, double y){return x * y;} },
    DIVIDE("/") {public double apply(double x, double y){return x / y;} };

    public abstract double apply(double x, double y);

    public final String symbol;

    Operation(String symbol) {
        this.symbol = symbol;

Item 35

  • Use instance fields instead of ordinals
  • enums have an ordinal method that returns an int for each member (in order they are defined, 0-index)
  • we might get tempted in some situations to get the ordinal() value and use it. Don't do this!!
  • if you need to associate a value with each member, even an int, use instance fields as explained in item 34.

Item 36

  • Use EnumSet instead of bit fields
  • when the enum elements are meant to be used in a set, traditionally many ppl use int enum pattern and instead of enum, for each element they define a different power of 2 and to pass them around they use bit field:
public class Text {
    public static final int STYLE_BOLD = 1 << 0; // 1
    public static final int STYLE_ITALIC = 1 << 0; // 2
    public static final int STYLE_UNDERLINE = 1 << 0; // 4
    // ...

    public void applyStyles(int styles) {...}

and to use them and passing them around, instead of set we can do this: text.applyStyles(STYLE_BOLD | STYLE_ITALIC); (we pass something like 100101 in which every 1 says we should apply that style)

  • Java.util package has EnumSet which should be used instead of these bit fields. it provides type safety and interoperability of sets and internally uses bit vector which makes its performance comparable with bit fields:
public class Text {

    public void applyStyles(Set<Style> styles) { ... }

and then we can use it like this:

text.applyStyles(EnumSet.of(Style.BOLD, Style.ITALIC));

note that applyStyles() takes Set instead of EnumSet, this is a best practice to accept the interface type rather than the implementation type (item 64), but it works fine if we accept EnumSet.

Item 37

  • Use EnumMap instead of ordinal indexing
  • it is rarely appropriate to use oridnals to index into arrays, use EnumMap instead.
    • if the relationship being represented is multidimensional, nested EnumMaps should be used: EnumMap<..., EnumMap<...>>
  • One example for using EnumMaps: consider this class representing a Plant:
public class Plant {
    enum LifeCycle { ANNUAL, PERENNIAL, BIENNIAL }

    final String name;
    final LifeCycle lifeCycle;

    // implement constructor and override toString to return name
  • so here basically each plant has a name and a life cycle. Now we want to have an array of plants representing a garden and we want to organize these plants by there life cycle. We can have an array of set (Set<Plant>[]) and use LifeCycle ordinal value to put each plant in one of the possible 3 sets or we can use EnumMap:
Map<Plant.LifeCycle, Set<Plant>> plantsByLifecycle =
                    .collect(gropuingBy(p -> p.lifeCycle,
                        () -> new EnumMap<>(LifeCycle.class),
                        toSet() ));

Item 38

  • Emulate extensible enums with interfaces
  • enum types are better that alternative enum patterns (such as int enum patterns). There is however one limitation which is one enum type can not extend another (generally not a good idea!)
  • in some cases such as operation codes, it might be still valid to have extensible enums. To emulate the extension, we can use interfaces like this:
  public interface Operation {
      double apply(double x, double y);

  public enum BasicOperation implements Operation {
      PLUS("+") {
          public double apply(double x, double y) { return x + y; }
      MINUS("-") {
          public double apply(double x, double y) { return x - y; }

      private final String symbol;

      BasicOperation(String symbol) {
          this.symbol = symbol;

      public String toString() { return symbol; }

  public enum ExtendedOperation implements Operation {
      EXP("^") {
          public double apply(double x, double y) { return Math.pow(x, y); }
      REMAINDER("%") {
          public double apply(double x, double y) { return x % y; }

      private final String symbol;

      BasicOperation(String symbol) {
          this.symbol = symbol;

      public String toString() { return symbol; }
  • this pattern lets clients to write their own enums and we can have methods using these enums that rely on their standard methods, for example we can have a method that accepts enums extending Operation and we call apply() method on its enum constants, knowing they all implement it
  • The only issue here is that there are some duplicated code for toString(). we can potentially use static helper methods to reduce code duplication in these situations

Item 39

  • Prefer annotations to naming patterns
  • Annotations in java are used to provide supplement information about a program. They help us associate metadata (information) with the program elements.
    • there are standard ones we can use (like @SupressWarnings, @Override, @Deprecated)
    • we can also define our own annotations
  • One example of defining our test annotation for a test framework:

    import java.lang.annotation.*;
    @Retention(RententionPolicy.RUNTIME) // it will be retained at runtime
    @Target(ElementType.METHOD) // it can be used only on methods (not classes, etc.)
    public @interface Test {
  • now we can write tests like this:

public class Sample {
    public static void testMethod() {}
  • now we can have a framework like this to find the annotated methods and run the tests:

    public class TestRunner {
        public static void main(String[] args) throws Exception {
            int tests = 0;
            int passed = 0;
            Class<?> testClass = Class.forName(args[0]);
            for (Method m : testClass.getDeclaredMethods()) {
                if (m.isAnnotationPresent(Test.class)) {
                    try {
                    } catch() {
                        ... // see full implementation on page 182, 3rd edition
  • we can also define our test annotation to have some associated values (e.g. for exception):

public @interface Test {
    Class<? extends Throwable> value();
  • we can use it on a method like this:
public static void badMethod() {
    int i = 3 / 0;

and when calling it in our test runner, we can check its value like this:

method.getAnnotation(Test.class).value(); // here it should return ArithmeticException
  • our custom annotations can contain more information:
public @interface User {
    String name() default "Ashkan";
    Long id();

and then we can use it like this:

@User(name="Ashkan", id=123L)
public AdminUser adminUser = new AdminUser();


  • this item recommends using annotations
  • there used to be some naming conventions (like JUnit 3 was looking for methods defined in a certain way -start with test) but now they use annotations which is much better.

Item 40

  • Consistently use the Override annotation
  • the @Override annotation may be used on method declarations that override declarations from interfaces as well as classes
    • with the advent of default methods, it is good practice to use Override on implementations of interface methods.
  • in an abstract class or an interface, it is worth annotating all methods that override superclass or interface methods, it provides extra checks and if by mistake you add a new method (e.g. by using a different method signature), it will warn you that what you are overriding does not exist in the parent

Item 41

  • Use marker interfaces to define types
  • a marker interface is an interface that contains no method declarations but merely designates/marks a class a class implementing it as having some property
  • if you find yourself writing a marker annotation type whose target is ElementType.TYPE (means any class or interface), make sure that you can't use a marker interface instead!
    • if you wanna add methods that accept only objects that have this marking, you should use interfaces
  • this is basically inverse of Item 22 (don't use an interface if you are not defining a type) and it says use an interface if you want to define a type

7 Lambdas and Streams

Item 42

  • Prefer lambdas to anonymous classes
  • historically interfaces with single abstract methods were used as functional types. Their instances are known as function objects which represent functions or actions.
  • Since JDK 1.1 the primary means of creating these function objects was the anonymous class (refer to Item 24). Since Java 8 it is made possible to create these functional interfaces in a much more concise way using lambda expressions:

    // using anonymous classes as a function object (obsolete!)
    Collections.sort(words, new Comparator<String>() {
        public int compare(String s1, String s2) {
            return, s2.length());
    // now using lambda expression as function object (instead of anonymous class)
    Collections.sort(words, (s1, s2) ->, s2.length()));
    // even better using comparator construction method instead of lambda:
    Collections.sort(words, comparingInt(String::length));
    // even more succinct using sort method added to List interface in Java 8:
  • remember from Item 34 in enum type Operation we used constant-specific class bodies and overrode apply() for each enum constant (since behavior was different for each constant). now instead of function objects we used in those examples of Item 34 to override apply(), we can simply do this:

public enum Operation {
    PLUS ("+", (x, y) -> x + y),
    MINUS ("+", (x, y) -> x + y); // omitted other operations for brevity

    private final static symbol;
    private final static DoubleBinaryOperation op;

    Operation(String symbol, DoubleBinaryOperation op) {
        this.symbol = symbol;
        this.op = op;

    public double apply(double x, double y) {
        return op.applyAsDouble(x, y);


  • Lambdas lack names and documentation, one to three lines are reasonable for a lambda expression, don't put more than that in a lambda since they are not very self-explanatory and may result in confusion and harm the readability.
  • you should rarely (if ever) serialize a lambda.

Item 43

  • Prefer method references to lambdas
  • the primary advantage of lambdas over anonymous classes is that they are more succinct
  • Java provides a way to generate function objects even more succinct: method references

    // lambda expression
    map.merge(key, 1, (count, incr) -> count + incr);
    // method reference:
    map.merge(key, 1, Integer::sum);
  • in the above example, lambda expression is a bit verbose and all it is saying is that the function returns the sum of its two arguments. we accomplish that by just using Integer::sum

  • in some situations lambda expression can be shorter that method reference (usually when the method is in the same class as the lambda). in these situations we better use the lambda version:

// vs.
service.execute(() -> action());
  • there are other cases like Function.identity() which is again better to use the lambda equivalent x -> x as it is shorter and more clear.
  • so whenever it is shorter and more clear, we should use method references, o.w. we should use lambdas.

Item 44

  • Favor the use of standard functional interfaces
  • now that Java has lambdas, best practices of writing APIs has changed considerably
  • now instead of having a subclass overriding a primitive method in superclass, we can provide a static factory/constructor that accepts a function object
  • when you want to accept functional interfaces you don't have to create the interface every time. First make sure it doesn't exist in java.util.function (unless you have a good reason not to use them)
  • there are 43 interfaces in this package but the main 6 are:
Interface               Function signature          Example
UnaryOperator<T>        T apply(T t)                String::toLowerCase
BinaryOperator<T>       T apply(T t1, T t2)         BigInteger::add
Predicate<T>            boolean test(T t)           Collection::isEmpty
Function<T, R>          R apply(T t)                Arrays::asList
Supplier<T>             T get()                     Instant::now
Consumer<T>             void accept(T t)            System.out::println
  • make sure you use these interfaces unless there are good reasons like
    • it will be commonly used and can benefit from a more descriptive name
    • it has a strong contract associated with it
    • it would benefit from custom default methods
  • one example is Comparator (where we don't use an existing interface)
  • when defining functional interfaces, use @FunctionalInterface annotation:
// for demonstration only, use the standard one under java.util.function:
interface EldestEntryRemovalFunction<K, V> {
    boolean remove(Map<K, V> map, Map.Entry<K, V> eldest);

Item 45

  • Use streams judiciously
  • Streams API was added in Java 8 and contains two key abstractions:
    1. the stream, which represents finite/infinite sequence of data elements
    2. the stream pipeline, which represents a multistage computation on these elements
  • streams are sufficiently versatile that practically any computation can be performed using streams.
    • but this doesn't mean we should!
    • when used appropriately, they make programs shorter and cleaner
    • otherwise they make programs difficult to read and maintain
  • as an example look at one implementation of program that reads words and prints them based on anagram groups (words with same letters, different combinations):
public class Anagrams {
    public static void main(String[] args) throws IOException {
        Path dictionary = Paths.get(args[0]);
        int minGroupSize = Integer.parseInt(args[1]);

        try (Stream<String> words = Files.lines(dictionary)) {
            words.collect(groupingBy(word -> alphabetize(word))).values()
            .stream().filter(group -> group.size() >= minGroupSize)
            .forEach(group -> System.out.println(group.size() + ": " + group));

    private static String alphabetize(String str) {
        char[] a = str.toCharArray();
        return new String(a);
  • things to consider in the above code:
    • we could make everything iterative or we could use streams everywhere. But this is the best and most concise implementation that combines streams and imperative paradigms:
    • we could implement alphabetize() using streams, but would've been less readable and less performant (streams are not efficient on chars as they don't support them)
    • we also extracted alphabetize() as a method and used it in our stream. Alternatively it could have been implemented using streams and used in the same stream, but it would have made the entire thing more complex, less readable and less efficient
    • we tried to use meaningful names in streams which clearly express the elements we are iterating on (e.g. word and group)
  • there are certain things we can't do from function objects (in streams) such as defining local variables and reading/modifying them in scope. Also we can't return from the enclosing method or break/continue or throw a checked exception:
    • in these situations we should avoid streams.
  • also there are situations in which streams usually makes more sense:
    • uniformly transform sequences of elements
    • filter sequences of elements
    • search sequence of elements for an element satisfying some criterion
    • accumulate sequences of elements into a collection (perhaps grouping them by some common attributes)
    • combine sequences of elements using a single operation
  • there are also some situations which it is not clear that which way is better or more efficient or more readable! in these situations we can go either way!


  • Overusing streams makes programs hard to read and maintain
  • in the absence of explicit types, careful naming of lambda parameters is essential for readability of stream pipelines.
  • using helper methods is even more important for readability in stream pipelines than in iterative code!

Item 46

  • Prefer side-effect-free functions in streams
  • Streams aren't just an api, they are a paradigm based on functional programming
  • they should have a sequence of transformations where the result of each stage is as close as possible to a pure function:
    • its result depends only on its input, it doesn't depend on any mutable state, nor does it update any state
  • compare the following two examples, the first one doesn't follow the paradigm but the second one is modified to follow the paradigm:
// uses streams but not the paradigm:
Map<String, Long> freq = new HashMap<>();
try (Stream<String> words = new Scanner(file).tokens()) {
    words.forEach(word -> {
        freq.merge(word.toLowerCase(), 1L, Long::sum);
// proper use of streams:
Map<String, Long> freq;
try (Stream<String> words = new Scanner(file).tokens()) {
    freq = words.collect(groupingBy(String::toLowerCase, counting()));

the problem with the first example above is that we use forEach to mutate a an external state (frequency table). But second example is modified so that it accepts a table and initializes the given table

  • the forEach operation should be used only to report the result of a stream computation, not to perform the computation
  • In order to use streams properly, you have to know about collectors. The most important collector factories are toList, toSet, toMap, groupingBy and joining.

Item 47

  • Prefer collection to stream as a return type
  • when writing a public API that returns a sequence of elements, we should provide for both users who want to use it in a stream pipeline as well as those who want to iterate on them.
  • Best option here is to return a Collection that provides both
  • the only thing to notice here is that if a return type is small enough to be kept in memory, we can use standard collection implementations such as ArrayList or HashSet. If it is large, we should consider returning a custom collection
    • one example is returning power set (all the sub-sets) of a given set: its space requirement is 2n space. Instead we can create a custom one based on binary representation of it (page 218 of the book for the implementation)

Item 48

  • Use caution when making streams parallel
  • Java has always tried to facilitate concurrent programming. First version of Java was released with thread support, Java 5 introduced java.util.concurrent library with concurrent collections. Java 8 introduced streams which can be parallelized with a single call to the parallel() method
  • although it is very easy to call the parallel method we should be very careful as it won't be very helpful in most of the cases and in some cases it can result in failure or performance disaster
  • in general whenever we want to use it we have to have good reasons and we have to prove that the code remains correct. Then we have to measure the performance before and after to make sure it actually improved
  • performance gains from parallelism are best on streams over ArrayList, HashMap, ConcurrentHashMap, arrays, int ranges and long ranges.

8 Methods

Item 49

  • Check parameters for validity
  • most methods and constructors have some restrictions on their parameters. We should properly document these and also check for their validity as soon as we can.
  • for public or protected methods use the Javadoc @throws tag to document the exception
  • the Objects.requireNonNull() is convenient and easy to use (for null checks)

Item 50

  • Make defensive copies when needed
  • you must program defensively with the assumption that clients of your class will do their best to destroy it!
  • as an example of how things can go wrong and how we can prevent them, consider the following class:
public final class Period {
    private final Date start;
    private final Date end;

    // 'start' must be before 'end'
    public Period(Date start, Date end) {
        if (start.compareTo(end) > 0) {
            throw new IllegalArgumentException();
        this.start = start;
        this.end = end;

    public Date start() {
        return start;

    public date end() {
        return end;
  • first of all never use Date as it is mutable and instead use java.time.Instant. The following code can break the validity of our Period instance:
Date start = new Date();
Date end = new Date();
Period period = new Period(start, end);
end.setYear(78); // modifies internals of period!
  • to fix this, we should make defensive copies in constructor:
public Period(Date start, Date end) {
    this.start = new Date(start.getTime());
    this.end = new Date(end.getTime());

    if (this.start.compareTo(this.end) > 0) {
        throw new IllegalArgumentException();

in the above code since we make a copy, it is impossible for the client to change the parameters. we also moved the validity check to after defining the defensive copies, this is to prevent scenarios like this: let's say another thread for example changes the value of parameters after we check their validity so by the time we assign them, they become invalid. but after we make our defensive copies, this can't happen and we can be sure that our Period instance is valid (and will remain valid)

  • there is one more thing we need to fix in this class to make it completely error prone. The getters we have defined will return the Date instances of the class and again their values can be altered out of the class (the variables are final but that's just the object reference, i.e. its value can change). We apply the same fix:
public Date start() {
    return new Date(start.getTime());
// we do the same for end()
  • same rules apply when you use a mutable object in your class and you know your class can't tolerate mutability in that reference (like you use the referenced object in a map as a key or in a set).

Item 51

  • Design method signatures carefully
  • choose proper method names
    • if there are naming conventions, obey them
    • choose the best name that conveys the purpose of that method clearly
    • ideally avoid very long method names
  • avoid long parameters list (maximum 4 parameters). There are different ways of making parameter lists shorter:
    • breaking the method into multiple methods, each with fewer parameters list
    • using helper classes/DTOs to pass around different parameters
    • using Builder patter (item 2) from object construction to method invocation
  • for parameter types, favor interfaces over classes
    • using classes will put unnecessary restrictions
    • e.g. as an input instead of accepting HashMap we can accept Map (someone may want to pass a TreeMap or a ConcurrentHashMap)
  • prefer two element enum types to boolean parameters
    • public enum TemperatureScale { FAHRENHEIT, CELSIUS }
    • Thermometer.newInstance(TemperatureScale.CELSIUS) versus Thermometer.newInstance(true)
    • we can also later expand the types under our enum type

Item 52

  • Use overloading judiciously
  • overloading is when two (or more) methods have the same name and different signatures. If not used carefully, it can get really confusing and generate unexpected results.
  • Choice of overloading (which overloaded method to be used) is determined at compile time and can cause issues:

    public String someMethod(Set<?> daSet) {
        return  "Set!";
    public String someMethod(Collection<?> daCollection) {
        return "Collection";

    in an example like this, user may call someMethod() with a set and expecting it to call the first method, while it may call the second one!

  • it can get really confusing when there is same number of parameters. One alternative in these situations which makes it very clear and error prone is to use different names:

    • like readInt(), readBoolean(), readLong() (instead of three overloaded read()s)

Item 53

  • Use varargs judiciously
  • vararg methods accept zero or more arguments of a specified type
    • they are life saver when we need variable number of arguments
  static int sum(int... args) {
      int sum = 0;
      for (int arg : args)
          sum += arg;
      return sum;
  • couple of small notes about varargs and their usage:
    1. if your method requires them to have at least one argument, we can check the argument size first thing and throw exception if it was zero:
  if (args.legth == 0) {
      throw new IllegalArgumentException("too few arguments");

but its messy and also more important, it fails at runtime (while it could've been caught at compile time). Best approach here is:

  static int min(int firstArg, int... remainingArgs) {
  1. we need to be careful in performance-critical situations as each each use of varargs causes an array allocation and initialization. In this situation if we know that 90% of the cases are 2 arguments or less and we want to optimize the program, we can do this:
  public void foo() { }
  public void foo(int a1) { }
  public void foo(int a1, int a2) { }
  public void foo(int a1, int a2, int... rest) { }

Item 54

  • Return empty collections or arrays, not nulls
  • There is no reason to return null when the array or collection that we were supposed to return has no members. It makes code messy, on the client side we need to add extra unnecessary code to handle null case first and then if it was not null, process the returned values. If we forget, we may get NPE. It also adds extra unnecessary code on our side as well to see if there are no members return null, if not return the collection (while we should've just returned that collection, even if it is empty!)
  • in very rare cases we can argue that returning null is more memory efficient than allocating an empty array or collection. First it is inadvisable to worry about performance at this level and usually unnecessary. In the unlikely event that you have evidence suggesting that allocating empty collections is harming the performance, you can avoid it by returning Collections.emptyList(), Collections.emptySet(), Collections.emptyMap(), etc.

    • in case of arrays, we can have an empty array and returning the same zero-length array repeatedly (zero length arrays are immutable):
      private static final Cheese[] EMPTY_CHEESE_ARRAY = new Cheese[0];
      public Cheese[] getCheeses() {
          return cheesesInStock.toArray(EMPTY_CHEESE_ARRAY); // if we want an empty array here

Item 55

  • Return optionals judiciously
  • Optionals represent values that can be either present or absent. Prior to Java 8, if a method was not able to return a value it could either throw an exception or return null. Optionals were added in Java 8 (java.util.optional), they are immutable containers that can contain either a non-null object reference or nothing at all (empty optional)
public static <E extends Comparable<E>> Optional<E> max(Collection<E> collection) {
    if (collection.isEmpty()) {
        return Optional.empty();

    E result = //find the maximum element
    return Optional.of(result);
  • passing null to Optional.of(value) will throw an exception.
  • many terminal operations on streams return optionals. Using stream in the above example will generate the optional for us:
public static <E extends Comparable<E>> Optional<E> max(Collection<E> collection) {
  • On the client side, they can decide what to do with an optional returned value. such as:

    // use a default value if optional is empty:
    String myString = max(words).orElse("No words...");
    // or throw an exception if it is empty:
    Toy myToy = max(toys).orElseThrow(TemperTantrumException::new);
    // if we know it's not empty we can just get the value:
    Element lastNobleGas = max(Elements.NOBLE_GAS).get();
  • if we have a stream of optionals and we want to get those elements of this stream that are not empty:


Java 9 added stream() method to Optional which returns only those elements that have value, so this last code snippet can be even shorter:



  • never return null from an optional-returning method
  • never return an optional of a boxed primitive type
    • this is expensive compared to returning primitive type because the optional has two levels of boxing instead of zero
    • you can use OptionalInt, OptionalLong and OptionalDouble if needed

Item 56

  • Write doc comments for all exposed API elements
  • to document the API properly, you must precede every exported class, interface, constructor, method and field declarations with a doc comment
  • The complete guide for writing java docs is here. This doc is a bit old (Java 4), since then, these tags have been added: {@index}, {@implSpec}, {@literal} and {@code}
  • the text following @param and @return should be a noun phrase, summary description should be a verb phrase. @throws should consist of the word "if" followed by the condition under which the exception is thrown:

    * Returns the element at the specified position in this list.
    * <p>This method is <i>not</i> guaranteed to run in constant time. In some
    * implementations it may run in time proportional to the element position.
    * @param index index of element to return; must be non-negative and less
    *              than the size of this list
    * @return the element at the specified position in this list
    * @throws IndexOutOfBoundsException if the index is out of range
    *         ({@code index < 0 || index >= this.size()})
    E get(int index);
  • there are some HTML meta-characters that should be skipped (such as & and <). also first sentence of each doc comment becomes summary description and this will be determined by a dot followed by space, so in this sentence we need to skip the second dot as well:

A college degree, such as B.S., M.S. or Ph.D.

in these situations we can use @literal or @code tags to skip these characters and render them properly

    * A college degree, such as B.S., {@literal M.S.} or Ph.D.
    public class Degree {...}
  • Doc comments should be readable both in the source code and in the generated documentation.

9 General Programming

Item 57

  • Minimize the scope of local variables
  • the most powerful technique is to declare them where they are first used
  • if local variable declaration doesn't contain initializer, perhaps we should postpone its declaration to when we have enough information to initialize it.
  • prefer for loops to while loops because they enforce local variables for iterators
  • keep methods small and focused
    • having a method doing two things (let's say task 1 and task 2), we may define local variables that is used for task 1 but it's not used by task 2!
    • to prevent this, simply separate this method into two

Item 58

  • Prefer for-each loops to traditional for loops
  • for different reasons such as being more succinct, less error prone and more flexibility we should use for-each loops when possible. Specially that they come with no performance penalty
  • we should be able to use for-each loops in different situations except when we need to access the iterator index for different scenarios such as removing or modifying an element at a certain index
for (Element element : elements) {
    // do something

Item 59

  • Know and use the libraries
  • By using a standard library, you take advantage of the knowledge of the experts who wrote it and the experience of those who used it before you
    • different functionalities in the libraries get developed and tested with all the edge cases and performance scenarios in mind, gets reviewed by the experts and then gets used by millions of developers. Discovered issues get fixed in future releases.
  • We should be familiar with standard libraries as well as high-quality 3rd party libraries such as Google's guava library

Item 60

  • avoid float and double if exact answers are required
  • these types are designed particularly for scientific and engineering calculations. They carefully provide accurate approximations quickly over a broad range of magnitudes.
  • they are specially ill-suited for monetary calculations
System.out.println(1.03 - 0.42); // 09999999999999998
  • use BigDecimal, int (or long) in these situations

Item 61

  • prefer primitive types to boxed primitives
  • java has two-part type system:
    1. primitives: such as int, double and boolean
    2. reference types: such as String and List
  • every primitive type has a corresponding reference type called boxed primitives
    • boxed primitives for int, double and boolean are Integer, Double & Boolean
  • primitives only have values but boxed primitives have identities distinct from their values. Primitives have only fully functional values whereas boxed primitives have non-functional value which is null. also primitives are more time and space efficient.
  • there are certain issues that we may encounter when using boxed primitives. for example:
    • if we compare them like this: integerOne == integerTwo almost always returns false when their values are equal! (because it compares their identities rather than their values)
    • when comparing Integer with int, it will automatically unbox the Integer to get its value and compare it with int. If Integer value is null, it will throw NPE!
  Integer i;
  if (i == 52) { // NullPointerException
  • there situations where we can't use primitives. Such as putting elements (or keys or values) in collections. For type parameters also we can't use primitives:
    • ThreadLocal<int> is not allowed, you must use ThreadLocal<Integer>
    • in summary, we should always use primitives where ever we have the choice.

Item 62

  • Avoid Strings where other types are appropriate
  • Strings are designed to represent text, they do a fine job of it. at the same time, they are poor substitutes for other value types.
    • poor substitutes for enum types (discussed in Item 34)
    • poor substitutes for aggregate types ( strings like 'className#2#true' that are meant to keep different values)
  • Used inappropriately, strings are more cumbersome, less flexible, slower and more error prone

Item 63

  • Beware the performance of string concatenation
  • using string concatenation operator on n strings requires time quadratic in n.
    • this is because strings are immutable
  • don't use string concatenation to combine more than a few strings
  • for a better performance, use StringBuilder in place of string:
public String statement() {
    StringBuilder stringBuilder = new StringBuilder(newItems() * LINE_WIDTH);
    for (int i = 0; i < numItems(); i++) {
    return stringBuilder.toString();

Item 64

  • Refer to objects by their interfaces

    // good
    Set<Son> sonSet = new LinkedHashSet<>();
    // bad
    LinkedHashSet<Son> sonSet = new LinkedHashSet<>();
  • If there is no appropriate interface, just use the least specific class that provides the required functionality

  • if we are using a class-base framework we can use the base class which is usually an abstract class

Item 65

  • Prefer interfaces to reflection
  • Using reflection, given a class object you can access its constructor, fields and methods and invoke them. This comes handy when you don't know the class to use until run time.
  • when using reflection:
    • you lose all the benefits of compile time type checking
    • the code required for reflection is verbose (see p. 283, 3rd edition for an example)
    • performance suffers
  • we should limit use of reflection as much as possible.
  • if possible we should create a class instance reflectively and then access the object using an interface or superclass that is known at compile time (to limit use of reflection)

Item 66

  • Use native methods judiciously
  • Java lets us call native methods written in native programming languages such as C/C++
    • they allow access to low level resources and platform specific facilities such as registries
    • they are also used to write performance-critical parts of applications
  • this item basically says that Java has changed a lot and added more features to make us independent of these native methods. it has also improved performance a lot.
  • we should rarely use native methods for improved performance
  • if we use them to access native libraries or low level resources, we should use as little native code as possible

Item 67

  • Optimize judiciously
  • this item says that we should avoid optimizing as much as possible! most of the effort is usually wasted and the results are usually negligible and sometimes worse!
  • instead we should focus on having a good architecture, which in nature is flexible, scalable and fast.
  • when you're done writing your application, use profiling tools to measure the performance
    • if it's fast enough, you're good
    • if not, locate source of problem, fix it and measure it afterwards to make sure you made improvements
  • no amount of low-level optimization can make up for a poor choose of algorithm

Item 68

  • Adhere to generally accepted naming conventions
  • there are generally two categories of conventions: typographical and grammatical
  • package or module
    • all lower case
    • ideally less than 8 characters
    • meaningful abbreviations are encouraged (util instead of utilities)
    • start with organization's internet domain in reverse order
    • org.junit.jupiter.api,
  • class or interface
    • CamelCase
    • abbreviations are to be avoided except for common ones such as min and max
    • Stream, FutureTask, LinkedHashSet, HttpClient
  • method or field
    • camelCase
    • except constants which are all caps, separated with under-score
    • remove, groupingBy, getCrc, MIN_VALUE
  • local variables are lest restricted since they have a limited scope and no visibility in the api. you can use i or abbreviations such as houseNum
    • personal note: I still prefer getting into the habit of more readable and meaningful names, specially given that all the modern editors have auto-complete (as mentioned in Clean Code)
  • type parameters are single letters, E for collection elements, T for an arbitrary type, K and V for key/value types in map, R for return types of methods and X for exception types. a sequence of arbitrary types are T, U, V or T1, T2 and T3
    • personal note: lots of developers prefer using full words to make it more clear and meaningful, such as Type instead of T or DataType instead of E, etc. (lots of articles about it online)
  • grammatical naming conventions are more flexible. none for package and module names. Class names (and enums) are usually singular noun (or noun phrases) such as ChessPiece, Thread,...
  • non-instantiable utility classes are usually plural noun such as Collectors or Collections
  • Interfaces are like classes (Collection) or end with -ible/-able like Runnable or Accessible
  • methods are verbs such as append, drawImage. if returning boolean, usually start with 'is' like isDigit, isEmpty or sometimes like hasSiblings
    • methods returning non-boolean usually start with 'get' like getTime but sometimes it can be more readable to avoid get like car.speed()

Top comments (0)