DEV Community

Discussion on: I've re-built my portfolio based on a Dribbble shot I found. What do you think?

Collapse
 
ben profile image
Ben Halpern

Really slick.

A couple thoughts:

  • The shadow should probably expand when the card expands, right?
  • I think there should be some min padding. The Slack card subheader goes right to the edge for me.

I think the general look here is nice. Giving some attention to the spacing, padding, and general small details will really make it polished.

Collapse
 
chipd profile image
Chris Dermody

The shadow should probably expand when the card expands, right?

Yep I think they should. Had a bit of trouble getting that to work though so left it for the moment. But yep, I agree

I think there should be some min padding. The Slack card subheader goes right to the edge for me.

Yep good call! it needs some padding to give some content room to breath!

Cheers for the feedback!