DEV Community

Discussion on: Lending some color to Tokei Code Analyzer

Collapse
chaelcodes profile image
Rachael Wright-Munn Author

Thanks! It was a fun build too.

Collapse
jonasbn profile image
jonasbn

Well having fun is the most important part.

I did not know NO_COLOR before you mentioned it, only CLICOLOR and CLICOLOR_FORCE. So now I am implementing it for one of my projects.

If anybody reads this comment and think, what are they talking about, check out:

Collapse
jonasbn profile image
jonasbn

BTW. I meant to ask you how you handled the interaction between CLICOLOR_FORCE and NO_COLOR. I then I found out the implementation is isolated to the colors crate, so I turned my attention to that release and did a small experiment and documented the result.

I have created a PR for colors outlining this in the documentation.

Thread Thread
chaelcodes profile image
Rachael Wright-Munn Author

Nice work! I love PRs that boost understanding like these. Do you do a lot of open-source PRs?

Thread Thread
jonasbn profile image
jonasbn

Yes, I try to contribute where I can.

Quite often it is related to documentation, because I find something hard to understand, explaining it to myself, might benefit others or if something is answered in an issue thread and I think it provides more value if promoted to the documentation.

I also write these Today I Learned notes (TIL) these sometimes, they end up as PRs or blog posts.