Nice! Typo / copy paste fail in the second code snippet I think -
if (!caches.match('/shell_top') || !caches.match('/shell_top')) { //return if shell isn't cached. return }
Second one should be shell_bottom right?
And by the way definitely got the near instant refresh effect you mentioned!
Same here. Even when i throttled the connection to Regular 2G.
Ha! Nice catch. Luckily for us it's highly unlikely shell_bottom is likely not missing unless shell_top is also missing. But we should definitely fix.
shell_bottom
shell_top
I'm going to start by fixing it in the demo above before patching it in the real code.
Feel free to do the honors if you'd like to submit the fix in the app itself...
github.com/thepracticaldev/dev.to/...
github.com/thepracticaldev/dev.to/... - hope I did it right, not done a PR on open source before!
Are you sure you want to hide this comment? It will become hidden in your post, but will still be visible via the comment's permalink.
Hide child comments as well
Confirm
For further actions, you may consider blocking this person and/or reporting abuse
We're a place where coders share, stay up-to-date and grow their careers.
Nice! Typo / copy paste fail in the second code snippet I think -
Second one should be shell_bottom right?
And by the way definitely got the near instant refresh effect you mentioned!
Same here. Even when i throttled the connection to Regular 2G.
Ha! Nice catch. Luckily for us it's highly unlikely
shell_bottomis likely not missing unlessshell_topis also missing. But we should definitely fix.I'm going to start by fixing it in the demo above before patching it in the real code.
Feel free to do the honors if you'd like to submit the fix in the app itself...
github.com/thepracticaldev/dev.to/...
github.com/thepracticaldev/dev.to/... - hope I did it right, not done a PR on open source before!