DEV Community

Discussion on: Build Job Listing Website in React JS

Collapse
 
grahamthedev profile image
GrahamTheDev • Edited

Doesn't work on mobile bud, tags appear off to the right.

Also didn't read the challenge but looking at the images I think you missed being able to filter on "featured", "new" etc. so you might need to add that.

From an accessibility perspective you need to use semantic elements as at the moment the whole page is not keyboard accessible. <button> elements for the tags, <ul> and <li> for the list of items etc.

Other than that looks good! Have you submitted your solution?

Collapse
 
codebucks profile image
CodeBucks

Hey,
I haven't focused more on mobile UI. I have tried only for 375px width as mentioned in the Design Guidelines. I just wanted to focus more on Logic part.

Well, Based on challenge there is no specific details about new and featured, but i have implemented that left side border which only appears when there is featured tag on job.

Thanks for your review and suggestions I'll try to make it better.πŸ˜„

Collapse
 
grahamthedev profile image
GrahamTheDev

Trying on iPhone and on resized browser and not working mobile layout as I said so that is your big fix.

As I said didn’t read brief it was just looking at the screenshots that it had β€œfeatured” as a filter option so I could be wrong there.

Looks great though! 😍