Accessibility Specialist. I focus on ensuring content created, events held and company assets are as accessible as possible, for as many people as possible.
Don't forget to use <label>s for your inputs and make sure they are properly associated (this is important for screen readers). You have done this with your checkbox correctly you just need to implement it on your inputs.
Also you don't need to use <input type="submit" anymore, a simple <button> will do the trick and make your markup cleaner.
Taking the time to focus on semantics will make your life as a developer much easier and learning good habits now will make you 10x better than most developers in no time looking at what you have done as a student, as this is 100 times better than what I would have done!
I'm Stanley Owen from Indonesia, pursuing my Bachelor's degree in Computer Science at the NTUST, Taiwan. These days, I'm particularly interested in web and app development.
Location
Taiwan
Education
National Taiwan University of Science and Technology
Hi InHuOfficial 👋. Sorry for the slow response, but I really appreciate your effort to write this comment✨. I have just recently updated the code on GitHub and of course on dev.to too! Happy Coding!
First of all, Stanley Owen and I appreciate your taking the time to write this comment. As developers of Fire UI, we actually focus more on the main library than the examples making the examples somehow written in not up-to-date HTML tags, we are really sorry for this negligence. Of course, we'll update this soon. Another factor of this causing is indeed Stanley Owen and I are both junior high school student making us, developers of Fire UI can only googling for learning, and as you know, today technology is evolving everyday and sometimes the query of Google shows up the result coming from the past years, which are maybe not relevant nowadays.
Of course, any contributions like Opening issues like this on GitHub, opening PR, using this Fire UI on your project, or even star it on GitHub, if you will, will be much appreciated.
This project will give you more understanding about HTML and CSS, but maybe asking someone for designing will make this project great , but overall Thumbs up ! Proud of you guys 👊
Don't forget to use
<label>s for your inputs and make sure they are properly associated (this is important for screen readers). You have done this with your checkbox correctly you just need to implement it on your inputs.Also you don't need to use
<input type="submit"anymore, a simple<button>will do the trick and make your markup cleaner.Taking the time to focus on semantics will make your life as a developer much easier and learning good habits now will make you 10x better than most developers in no time looking at what you have done as a student, as this is 100 times better than what I would have done!
Hi InHuOfficial 👋. Sorry for the slow response, but I really appreciate your effort to write this comment✨. I have just recently updated the code on GitHub and of course on dev.to too! Happy Coding!
Sincerely,
Stanley Owen
First of all, Stanley Owen and I appreciate your taking the time to write this comment. As developers of Fire UI, we actually focus more on the main library than the examples making the examples somehow written in not up-to-date HTML tags, we are really sorry for this negligence. Of course, we'll update this soon. Another factor of this causing is indeed Stanley Owen and I are both junior high school student making us, developers of Fire UI can only googling for learning, and as you know, today technology is evolving everyday and sometimes the query of Google shows up the result coming from the past years, which are maybe not relevant nowadays.
Of course, any contributions like Opening issues like this on GitHub, opening PR, using this Fire UI on your project, or even star it on GitHub, if you will, will be much appreciated.
A user-friendly and reliable CSS library
Fire UI
Table of Contents
Quick start
There are several quick start options available:
git clone https://github.com/fire-ui/fire-ui.gitforkon this repository and typegit clone https://github.com/<Your username>/fire-ui.gitnpm i @fire-ui/fire-uiBug and feature requests
Have a bug or a feature request? please open an issue if your problem or idea is not addressed yet.
Contributing Guidelines
Thanks for your interest in contributing to Fire UI! Please take a moment to review this document before submitting a pull request.
Code of Conduct
For the Code of Conduct, please visit CODE_OF_CONDUCT.md
Our lovely community
Shoutout to all stargazers and contributors!
LICENSE
Best regards,
Justin Maximillian Kimlim
This project will give you more understanding about HTML and CSS, but maybe asking someone for designing will make this project great , but overall Thumbs up ! Proud of you guys 👊
Thank you for commenting! Fire UI is free and open-source, if you will, you are more than welcome to contribute to make it better :)