DEV Community

Jonathan Hall
Jonathan Hall

Posted on • Originally published at jhall.io on

1

When is a pull request too big?

Smaller pull requests are faster to write and easier to review. But how do you know when your pull request is getting “too big”?

There’s no hard and fast rule, but here are a few “yellow flags” for your consideration. If you start to see your PR crossing one of these thresholds, ask if you can push what you’ve done, and save the rest for another PR.

  • Does the PR have more than 50-100 lines of changes?
  • Does the PR touch more than 5-10 files?
  • Does the PR contain more than 5-10 commits?
  • Does the PR contain changes written more than 8 hours apart?

If you enjoyed this message, subscribe to The Daily Commit to get future messages to your inbox.

Image of Timescale

🚀 pgai Vectorizer: SQLAlchemy and LiteLLM Make Vector Search Simple

We built pgai Vectorizer to simplify embedding management for AI applications—without needing a separate database or complex infrastructure. Since launch, developers have created over 3,000 vectorizers on Timescale Cloud, with many more self-hosted.

Read full post →

Top comments (0)

Billboard image

The Next Generation Developer Platform

Coherence is the first Platform-as-a-Service you can control. Unlike "black-box" platforms that are opinionated about the infra you can deploy, Coherence is powered by CNC, the open-source IaC framework, which offers limitless customization.

Learn more

👋 Kindness is contagious

Please leave a ❤️ or a friendly comment on this post if you found it helpful!

Okay