DEV Community

Discussion on: Re-implementing jQuery methods in the HTMLElement prototype

View post

Replies for: That wouldn't work because '' would evalute to false and in your code it would be the same as $('#el').html(). Check it running: codepen.io/fernan...

 
jochemstoel profile image
Jochem Stoel •

Well whatta ya know. You are right.
Change the line 

if (!string)

into this

if (typeof string == 'undefined')

so that you get 

window.$ = (query, ctx = document) => ctx.querySelector(query)
window.$$ = (query, ctx = document) => ctx.querySelectorAll(query)

HTMLElement.prototype.html = function (string) {
    if (typeof string == 'undefined')
        return this.innerHTML
    this.innerHTML = string
    return this
}

$('#test').html('');

codepen.io/jochemstoel/pen/OrJLbR

You can also replace it with

if(typeof string != 'string')

or even

if(string == undefined)