DEV Community

Discussion on: Great Examples of Issues and Pull Requests

Collapse
 
markerikson profile image
Mark Erikson

Two examples from React-Redux :

  • In 2016, a user filed an issue asking for changes to how we calculate props for child components. I had just been given maintainership by Dan Abramov, so I barely felt like I had enough authority to say how things ought to work, but I kinda dismissed the suggestion. The user came back a couple weeks later with a PR rewriting the guts of the lib entirely, and claimed it got faster. I asked if he'd considered edge cases, and he kept updating the PR in response to my comments. Eventually I realized he was serious about this and that his approach actually was an improvement. We iterated for a while, and that ended up as React-Redux v5. (Refs : React-Redux issue #407: Rewrite connect, The History and Implementation of React-Redux
  • We released v6 in early 2019. I'd chosen a different architectural direction that seemed necessary at the time, but unfortunately didn't written well enough in practice. So, I posted React-Redux issue #1177: React-Redux Roadmap: v6, Context, Subscriptions, and Hooks. This turned into a monster issue as I prototyped what became v7, and we debated implementation approaches.

The threads for discussing what became our v7.1 hooks API were pretty epic as well.

Collapse
 
nickytonline profile image
Nick Taylor

Awesome! Thanks so much for sharing Mark! 👏