I really like the code review section. I completely agree with the fact that Clean Code is really important, but trade offs in reality are going to come.
I think the first section about imposing unit tests is debatable. Yes TDD is a god send in terms of development style, but even though developers don't do it making them have unit tests would be better to not having them. That being said i agree that TDD needs to be taught at a practical level.
"A Developer Hour where programmers can exchange tricks and knowledge." Added to my "Things to do when I'm a manager" List.
Feedback section was good food for thought. Radical Candor Looks interesting.
Thank you for sharing this, Im coming to my 2 years of experience and a lot of this resonated with me :)
Thanks! I agree, the TDD section (like any other) is absolutely debatable. Perhaps I can provide some more context to help me clarify why I think it was not a good idea:
Enabling Unit testing was not something easy by any means given the framework and product we were working with (+ we had problems with PhantomJs crashing and replacing it with Chrome). Nobody had previous experience with the particular way we had to set up our test cases, so that resulted on a stepped curve which took some time to climb.
And in the end very few of our devs were actually using/knew about TDD.
Regarding what you mentioned that some tests are better than no tests at all, it is true that some times a developer can implement them as a way to document his code, even when the coverage is minimum, and I think that's a good alternative for tests when there is no TDD, but in my project many tests are simple checks for initialization which usually don't add any info.
For further actions, you may consider blocking this person and/or reporting abuse
We're a place where coders share, stay up-to-date and grow their careers.
I really like the code review section. I completely agree with the fact that Clean Code is really important, but trade offs in reality are going to come.
I think the first section about imposing unit tests is debatable. Yes TDD is a god send in terms of development style, but even though developers don't do it making them have unit tests would be better to not having them. That being said i agree that TDD needs to be taught at a practical level.
"A Developer Hour where programmers can exchange tricks and knowledge." Added to my "Things to do when I'm a manager" List.
Feedback section was good food for thought. Radical Candor Looks interesting.
Thank you for sharing this, Im coming to my 2 years of experience and a lot of this resonated with me :)
Cheers!
Thanks! I agree, the TDD section (like any other) is absolutely debatable. Perhaps I can provide some more context to help me clarify why I think it was not a good idea:
Enabling Unit testing was not something easy by any means given the framework and product we were working with (+ we had problems with PhantomJs crashing and replacing it with Chrome). Nobody had previous experience with the particular way we had to set up our test cases, so that resulted on a stepped curve which took some time to climb.
And in the end very few of our devs were actually using/knew about TDD.
Regarding what you mentioned that some tests are better than no tests at all, it is true that some times a developer can implement them as a way to document his code, even when the coverage is minimum, and I think that's a good alternative for tests when there is no TDD, but in my project many tests are simple checks for initialization which usually don't add any info.