Overview
This week I was working on two tasks + reviewing some PRs.
First PR
This one was nice an easy. It just added a create button on domains screen that redirected to create domain screen.
https://github.com/DevelopingSpace/starchart/pull/207
It was approved and merged with no problem
Second PR
This one was way more complicated. It basically adds fetching of domains (aka records) from server instead of showing them from the local mock file. I faced some problems and find some solutions which you can read about in PR description
https://github.com/DevelopingSpace/starchart/pull/242
I feel like it gonna take some time to merge this PR since it has a lot of controversial things to discuss about.
Code reviews
Also did some code reviews on some Front-end and Back-end pull requests. Tried to get involved in them more this week and review not only front-end code.
Top comments (1)
nice!