DEV Community

Don't follow RxJS Best Practices

Nik Poltoratsky on July 15, 2019

Nowadays more and more developers learn RxJS and use it properly with best practices in mind. But we shouldn't. All those so-called best practices ...

Read full post

Gabriel Magalhães dos Santos • Jul 15 '19

I could smell the junior's developer happiness reading this article

KristijanFištrek • Jul 15 '19

🤣

benjamin DELPECH • Apr 11 '24

i could smell the javascript framework expert feeling superior because he knows some tricks.

halcaponey • Jul 15 '19

getUser().pipe(
  switchMap(user => getDetails(user)),
  switchMap(details => getPosts(details)),
  switchMap(posts => getComments(details)),
)

should be

getUser().pipe(
  switchMap(user => getDetails(user)),
  switchMap(details => getPosts(details)),
  switchMap(posts => getComments(posts)),
)

but really should be

getUser().pipe(
  switchMap(getDetails),
  switchMap(getPosts),
  switchMap(getComments),
)

Good article, made me smile

Nik Poltoratsky • Jul 15 '19

Thank you! Fixed

Martín Emanuel • Jul 15 '19

For a moment I tought you were serious. But when you said no to pure functions I had to stop reading. Not gonna lie, you got me at the beginning.

Mark Flegg • Jul 18 '19

Haha, same here... at first I was thinking, "this is interesting," then "these ideas are a bit strange," then when I got to the no pure functions part I had to scroll to the bottom to see if it was a joke.

Pato • Oct 31 '19

sameee hahah

Mihail Malo • Mar 22 '20

Is this actually a good one?

takeWhile(() => this.alive)

Wouldn't this only trigger once the source tries to push a value, so if a value is never pushed the subscription is never garbage collected?
Seems vastly inferior to

destroyed$ = new Subject()

Dexter St-Pierre • Jul 15 '19

We have code in our codebase that is like this.. And the people that wrote it were senior developers...

Nik Poltoratsky • Jul 15 '19

I’m not telling you mustn't do that. In some particular cases, it is acceptable, so hopefully, everything is okay with your codebase 😁

Dexter St-Pierre • Jul 15 '19

Eh, in the case of our code base it is not acceptable cases. But we are working on fixing the issues :D

Nik Poltoratsky • Jul 15 '19

Hmm, then, good luck 😉

InnerC#ity • Jul 15 '19

Fantastic!! Well done Nikita! :)

KristijanFištrek • Jul 15 '19

Ohh you sneaky, you! The pure function one killed me 😅

Loic Coenen • Aug 18 '20

There's something I really don't get though. For me the difference between dumb and smart component is that the later doesn't communicate directly with the store or any other services, not that we can't pass down observable.