DEV Community

loading...

What was the worst feedback you got from code review?

pavel_polivka profile image Pavel Polívka ・1 min read

What was the worst feedback you got from code review?
How did you dealt with it?
Was the reviewer jerk to you?
Did you fight back?

Discussion (1)

Collapse
dthomason profile image
David

This question struck me as odd, because when I thought about it. Ya I’ve received some requested changes that got me frustrated a bit because I had to put more time in after thinking I was done. But all and all I appreciate any bit of feedback I can get. If I don’t see at least one comment from each requested I start to wonder if what I’m working on is even value add. Also some people may come across as rude or whatever but they’re really just trying to cover all the bases and good for them for being courageous enough to say what they think. That’s how solid things are made, because there’s always multiple ways to skin a cat, but at the end of the day that extra hand is a hand getting scratched instead of yours.

Forem Open with the Forem app