Skip to content
loading...

My first TypeScript open source contribution

po5i profile image Carlos Villavicencio github logo ・1 min read  

While working on a story, I was asked to upgrade the openpgp Node dependency, but bad luck a lot of tests broke.

After digging a bit and implement the included changes the code was not compiling due to some issues with the types. I forgot to mention that I'm using TypeScript for this one. So many types were outdated so I decided to open a PR to the types library DefinitelyTyped. Here's the PR:

Update openpgp type definitions to support async functions #30351

po5i avatar
po5i posted on

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

It got merged really fast and now my name is part of the authors

I found this bigger than the one I did for Babel:

Bumped lodash version #7895

po5i avatar
po5i posted on
Q                       A
Fixed Issues? No
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR No
Any Dependency Changes? Yes
License MIT

Bumped lodash dependency version due to a known vulnerability described here: https://nodesecurity.io/advisories/577

Happy coding!

twitter logo DISCUSS
Discussion
markdown guide
Classic DEV Post from Jul 30 '19

PublishTo.Dev: Scheduling article publishing on dev.to

Carlos Villavicencio profile image
Software development enthusiast. I am constantly learning and growing. I love supporting and building communities. Outside the programming world, I'm an amateur photographer and martial artist.