Introduction
For the last part of the Release 0.3 assignment for DPS909, we had to review two pull requests from the internal repositories. This included Telescope and IPC144.
Code Review 1
The first code review was in the IPC144 repository. Here is the link to my review. Overall the submitted markdown file was very well audited, however, I did notice that there were some code blocks that were not utilizing any type of syntax highlighting, so I reviewed the PR and commented that there should be a possibility of using the c
syntax within those two specific code blocks.
Code Review 2
The second code review was also in the IPC144 repository. Here is the link to my review. I audited the entire pull request file called More Input and Output.md
, and noticed that the author did a great job with their audit. I let them know that I reviewed everything and that it all checked out. I left a comment and approved the pull request.
Conclusion
Overall, I really liked this part of the assignment as it let me review and check other students code, and gave me some real world experience with reviewing pull requests. The process of reviewing a pull request is very important, as it ensures that only the highest quality code gets pushed into the main
branch.
Top comments (0)