DEV Community

Discussion on: It's nice to be nice! - Code Reviews

Collapse
scottshipp profile image
scottshipp • Edited on

Ah the classic one word code review comment:

  • Nope.
  • Fix.
  • Why?
  • Seriously?
  • Lame.

etc.

It's hard to believe you could see comments like this in modern times, but you do.

Collapse
tschaka1904 profile image
Maximilian Koch Author

I find myself sometimes in a "battle of arguments". Very subjective opinions, everything gets questioned for the sake of because one doesn't like it. And suddenly there is a pull request with 60+ comments. Also not really effective.

I remember one particular situation, when there was an argument about if the http-error-code should be displayed in the UI or not. That one had a total of 80 comments.

After getting some sort of feeling for those kind of situations, I've started to cut down those comments by saying: "If you have any further questions around this, I'm more than happy to describe the reasons behind this on a white or on-screen. Just let me know."

"Lame" is also a rather interesting one!