For the impatient
Don't do this
<body>
<div id="root"></div>
</body>
Enter fullscreen m...
For further actions, you may consider blocking this person and/or reporting abuse
I totally agree, to separate concerns it's a best practice that all of us should follow, for more than one reason. To change or remove something that could be used elsewhere without first look for its usages can do serious damage; separation of concerns puts a limit on it, but also help us to simplify and isolate problems and makes easier to understand the codebase.
However, I wonder: is it possible that there are significant performance differences between
getElementByIdandquerySelectorthat make using the id instead of the data attribute a risk worth taking?Loss of performance is certainly a factor in a JS application where you need to get dozens of elements or more. If that's the case, you should measure then optimize if needed. And an easy optimization is to use ids and
getElementById().The initialization code for a React app is just one
querySelector()at the start, tho, and with a simple selector. I don't expect the difference in performance to be perceived by users of the app :)html.spec.whatwg.org/multipage/dom...
There is clearly nothing harmful at all. Ids are made to direct targeting a UNIQUE element in the dom. There is nothing in the specification that prevent anyone to use it, especially when scripting.
The way you want to separate CSS from the code is ok, but don't say something is harmfull just without any real materials.
Modifying the production server in the middle of the night for CSS purpose is Harmfull, not targeting Id. This is only your opinion, no real proof of any kind in any official documentation. Your example makes no sense.
No one do that in real life. And if you delete the line ... You delete attribute too.
Wow, dude. So much hate.
I'll try this! Nobody in their right mind would touch it :D