Kotlin Code Smell 11 - God Objects

TL;DR: Avoid taking on excessive responsibilities. Use the single responsibility principle.

Problems

• Lack of cohesion

• Tight coupling

Solutions

• Split responsibilities.

• Follow the Single Responsibility Principle.

• Follow The Boy Scout Rule.

Examples

• Libraries

Exceptions

• Facades

Sample Code

Wrong

class Soldier {
    fun run() {}
    fun fight() {}
    fun driveGeneral() {}
    fun clean() {}
    fun fire() {}
    fun bePromoted() {}
    fun serialize() {}
    fun display() {}
    fun persistOnDatabase() {}
    fun toXML() {}
    fun jsonDecode() {}
    //...     
}

Right

class Soldier {
    fun run() {}
    fun fight() {}
    fun clean() {}
}

Conclusion

In Object-Oriented Programming, we distribute responsibilities among multiple objects.

---

Stay updated with my latest thoughts and ideas by registering for my newsletter. Connect with me on LinkedIn or Twitter. Let's stay connected and keep the conversation going!

---

More info

• God object - Wikipedia

• The S.O.L.I.D principles - Wikipedia

• Refactoring Guru

• Coupling

Credits

• Code Smell 14 - God Objects by @Maxi Contieri⭐⭐⭐