How can I request a review from a member of the React core team?

#react

I submitted a PR to React, which successfully fixes a bug. When I ran the official test suite with yarn test , it even passed two more tests than before.

I also linked it to my local project and conducted manual tests, confirming that the bug has indeed been resolved.

My PR:
https://github.com/facebook/react/pull/34116

However, a week has passed and there’s been no response—it’s like it’s fallen into a black hole.

Could you please advise on how I can contact React team members to request a review of my code?

Any suggestions are welcome! ：)

Top comments (1)

lionel-rowe • Aug 10

Big repos like React with lots of PRs tend to take a long time to land PRs, especially from new contributors, but there are some things that can help get your PR landed quicker:

Small diffs are generally better than large diffs as they're a lot quicker to review. Ideally it should be a minimum diff that fixes the problem, passes existing tests, and includes new tests. Your diff is already very small, which is good.
Make sure the newly added tests properly cover edge/corner cases, but without any unnecessary repetition (e.g. if testing a "capitilize-my-word" function, you might want tests for inputs "", "a", "A", "aa", "AA", but there's no point testing "b" once you already tested "a"). The new tests should fail without the fix but pass with it.
Most projects prefer you to link an issue that's closed by the PR, e.g. "Closes #9999".
Check the project's CONTRIBUTING.md to make sure you fulfilled all the requirements.
Include a summary of changes in the PR itself, but ideally keep it concise (yours is kinda long — that level of detail should be included in the linked issue instead).
Don't @ maintainers too often, they'll just get annoyed by it, as they usually have a lot of other PRs/issues/etc to get to. It's probably OK to @ them if you've been waiting a few weeks for an answer to a concrete question, but not multiple times a week.