Why the need for the case statement?
if (userMissedAppointment) { return 'nope'; } const userMeetsTechRequirements = userHasAngularExperience || userHasReactExperience || userHasVueExperience; if (userMeetsTechRequirements && userCanStartInstantly) { return 'hire'; } return 'maybe'
Also, imo, there's no need to repeat "user" in these flags. You could just say canStartInstantly, for example. There's no ambiguity regarding who this refers to.
canStartInstantly
Totally agree, but would you merge it if it was in a PR for instance?
Nope, I'd request changes here.
Are you sure you want to hide this comment? It will become hidden in your post, but will still be visible via the comment's permalink.
Hide child comments as well
Confirm
For further actions, you may consider blocking this person and/or reporting abuse
We're a place where coders share, stay up-to-date and grow their careers.
Why the need for the case statement?
Also, imo, there's no need to repeat "user" in these flags. You could just say
canStartInstantly, for example. There's no ambiguity regarding who this refers to.Totally agree, but would you merge it if it was in a PR for instance?
Nope, I'd request changes here.