DEV Community

Cover image for πŸ”₯ How to merge a pull request
All In Developer
All In Developer

Posted on Edited on Originally published at all1n.dev

πŸ”₯ How to merge a pull request

GitHub gives you three buttons to merge a pull request, and most teams pick one and use it for everything. Each of them leaves a very different history behind, though, and the right one depends on what’s inside the pull request.


πŸ‘‰ Continue reading on my blog: πŸ”₯ How to merge a pull request

Top comments (3)

Collapse
 
sargalias profile image
Spyros Argalias •

Wow. This is a really good strategy. Very nice tip, thanks! Squashing bad commits and commit messages sounds great as sometimes the source history for a branch is not useful anyway.

Usually my team aims for good commits like in your last point, but it doesn't always happen.

Collapse
 
all1ndev profile image
All In Developer •

Check out this conventionalcommits.org

Collapse
 
sargalias profile image
Spyros Argalias •

Thanks very much. That's already what I use ;). Highly recommended for everyone.