I've been a professional programmer for the last several years. During this time I've risen rapidly through the ranks. I started as an intern, but ...
For further actions, you may consider blocking this person and/or reporting abuse
I don't find the
elseworth targeting for the sake of readability. In fact, I welcomeelseas an explicit sign of "this or that" logic.Guard clauses are fine. Nested conditionals are another problem entirely.But I don't think breaking a simple function with 3 parameters into at least a combinations of small function with a long chain of
get by this and by thatis anymore readable.It does however make you think about reusability and keeping consistency in code, in the getCharities example there, is something that could be reused elsewhere.
Sorry, but I don't see why reusability is relevant here - when it was suggested to create multiple 'versions' of
getCharitieswith different combinations of parameters to avoid branching. One could even argue that it is the exact opposite of reusability: duplication.Unless we have wildly different logic for getting by
countryortier- in which case it isn't even about branching as they would be two different functions in the first place, what we would most likely have is this:getCharitiesByCampaignAndCountry -> return getCharities(country, campaign, defaultTier)Why make the reader jump an extra hoop just to get to the actual logic? And even if we were to force reusability on this, what is more reusable:
getCharitiesorgetCharitiesByCampaignAndCountry?I know the example are meant to be simple, sometimes contrived, but this is precisely why I don't see why eliminating
elsehelps in any way with readability.@dglsparsons , excellent points. However, the code examples are a little difficult to read as all of the code is in the same line. Better readability can be achieved if it is something like below.
Hey - thanks for pointing this out. I'm not sure what's happened there.
I've fixed it now, so hopefully its much easier to read!
New line before
returnplease :3While I agree with many of these points, and definitely find excessive cases of indentation in more novice-written code, this reads far more like "do as I say because I do it this way". You even start this with gloating that fits right with that motivation. Do you have studies on readability and how this change impacts that? While I suspect it does increase it, the wording of your article goes against your intentions.
You can look at how people talk when explaining something. I apply same technique and find it very useful. My motivation for this technique and some other comes from psychology and some linguistics. My coworkers whom I mentor think this is valuable technique, but maybe they do not know better. I cannot find studies regarding applicability of the technique in the real world even if I look for it deliberately. If you know what entity can do such kind of research I’m more then happy to start search again to prove or disprove statements of an article.
My anecdotal evidence is that code written in such way easier for novices to follow, since this kind of code can be easier to reading out loud and it would appear more natural.
Also there usually when express business logic there two kind of code intermixed, guards and shortcuts which require early exit to simplify logic and actual business logic where this rules less strictly applicable.
Why early exits and shortcut processing important? Try to remember how rare cases handled by business persons(can be engineers from other fields). Most people concentrate on core process and for other conditions usually throw simple shortcuts and suggestions which solve problem from their perspective. Such style of code just reflect how business people usually talk, just in slightly more formal way
Hi. Thanks for the feedback. That's not my intent at all, but I'm sorry it's come across that way. It's more intended to be - this is what works in my experience but I appreciate your perspective.
I'll bear this in mind in future :)
I didn't think it was, hence saying I agree with your point. I just saw an easy way others can discredit your message and I don't think it's a message that should be discredited. I'm glad hostility didn't come through in text, because my intentions were only constructive.
Congrats on publicizing this idea! I led integration teams for years and I tried to explain to them why nested if/else statements negatively impact the ability for other people to read and maintain code.
Code is always easier to deal with when its flow is kept as linear as possible and the happy path is clear. I think most people I spoke with never got this concept and it is good to see this.
Wow !
Nice article!
I think we should avoid ELSE and also IFS
How to Get Rid of Annoying IFs Forever
Maxi Contieri ⭐⭐⭐ ・ Nov 9 '20 ・ 5 min read
I like the extract you made on your function. I don't know why you call them helper. Who are they helping ?
Thank you for your article
Hi, thanks for reading - I'm glad you enjoyed the article. I'll definitely give yours a read too :).
You're right about calling them helper functions - I think it's a kind of industry standard term (or at least it is here), for separating out pieces of logic into plain functions. As for who they help... I'm not sure either. Probably us developers :D
Yes. I'm aware of that
But I think we are wrong. Calling something a 'Helper' is a code smell of a real world entity we are too lazy to find.
Here are some reasons not to use that name.
Arguing with standards or convention is a difficult line to take though.
e.g. why are most keyboards in a QWERTY layout? - it's an outdated convention from when typewriters would jam, but that doesn't mean keyboard or laptop manufacturers should deviate.
I've not come across a different terminology for a helper function personally. Calling it just a function could suffice but doesn't make a succinct point. As long as it's widely understood, I think it's okay - coming up with a different term could just cause more confusion.
Agreed with the standard part
I'm not suggesting replacing Helper with another standard.
I'm suggesting to change every helper to an intention revealing name according to the domain
in your case I think charitiesByCampaignAndCountry(campaign, country) is a very good name related to domain. But it is not a helper :)
I'm absolutely agreed with the names of the functions. Although I'd argue that as a concept, the function is still a helper 😜 (insofar as it's separating out the logical act of getting charities from the specific invocation of it).
I have been avoiding else blocks for quite some time now. But I have never been able to clearly explain the 'why'. For some reason the code felt cleaner without the else blocks. This article explains the 'why' part beautifully.
Interesting concepts about code readability, but I respfully agree.
I think that putting the else statement on its own line greatly improves the "line of sight" readability:
if( condition ) {
// statements
}
else {
// statements
}
Also, what about loops? They also break the same "line of sight" readability. What about switch statements? What about continue and break statements inside loops and switch statements? What about raising exceptions?
I think that helper functions also worsen the readability. For a programmer taking over or reviewing somebody else's code, helper functions definitely interupt the readability of the code.
I kicked 'else' to the curb over ten years ago. Best thing I ever did. As a dev lead, I teach those I mentor that it is similar to 'goto' and just doesn't have a place in modern object-oriented languages (C#, Java, python, typescript, javascript). I tried for a long time to use find a valid use of 'else' and 'goto' and every time I thought I had one, I realized there was a better way. Using either is always a code smell.
The author missed discussing one of the best reasons for not having an 'else' statement. Cyclomatic Complexity decreases. Give Cyclomatic Complexity a google or bing search and read up on it. Using 'else' always increases cyclomatic complexity and always makes unit testing and code coverage harder to obtain.
I am not sure I would recommend this technique when it creates negative logic.
How do you mean 'negative logic' ?
The code showed this:
function doSomething() {
if (something.OK()) {
return something.Do()
}
}
It was changed to:
function doSomething() {
if (!something.OK()) {
// return or throw error
}
return something.Do()
}
My experience has been that using a "not" in front of a conditional requires a mental adjustment to process the "negative" condition. I think I also read this on many books that talk about "code smells"
I think it depends on the properties/methods you have. I agree with your point that putting 'not' in front of a conditional can require a mental adjustment, but that's usually when you're properties are negative or poorly named.
For example - if I had a
something.notOK()method, I wouldn't want to negate this - as!something.notOK()doesn't read very nicely.That's an extreme example, but it's why naming is super important (especially for booleans).
Another example could be flagging users as
inactive- the logical thing to do is to add a boolean propertyisInactive. This isn't as obviously terrible, but inverting this can be confusing -not isInactive... so active.I'd argue the code smell there is the names / properties, rather than inverting the if / else statements though.
Great point though <3
He means inverted logic, not negative logic. In boolean terms, they're equivalent.
Interesting point! I do try to avoid else statements but only to keep my code short.
I think the word NEVER is too strong, sometimes ‘else’ does help readability.
Inverting the if statements is a good technique but most of the time it hurts readability, you need to pause and adjust your thought to the negative statement.
Anyways good article, great spark for discussion
So your problem is identation?
if(condition){
...
}
else{ // you can put else here
...
}
Hey. Thanks for taking the time to read the article and sharing your thoughts.
My issue isn't with the indentation of the
elsekeyword, but more that the happy-path code, and error-handling code are both indented within theif {} else {}statement - it makes them harder to distinguish from a quick scan.I'm sorry, but this is wrong, and I'm not going to be kind about it.
I remember years ago when people started saying 'never use goto in C'.
The real reason for that was the provability of source code. With GOTOs littered all over, it's impossible to prove the output of a program. Without them, it is possible.
For safety-critical software, like flight controllers and medical devices, that's damned important.
Is this the reason people gave when shouting at the top of their lungs 'if anyone in this team uses GOTO, they're out the door!' ? No. It is not.
At the time, coders put up all sorts of other arguments about style, readability, maintainability and even occasionally, simple personal preference. These are all fair reasons, and there was never any justification for littering code with GOTOs, especially conditional ones! In many systems, it was even essential to use GOTO in some places. But I digress...
Your argument for avoiding ELSE is hollow. Source code style and layout is not hindered by ELSE at all. If used correctly, with decent coding style, it looks rather nice and obvious. Avoiding it often makes functions longer or hides their logic, when a clearly stated ELSE case is very straightforward. Of course we don't want 10 levels of indented IF..ELSE..IF.. but that's obvious, isn't it? No reason to ban the ELSE word.
In the real world, we've got more important things to concentrate on, and I don't think you will find the ELSE statement disappearing from any language anytime soon!
If anyone wants to try writing all their code without ELSE, go for it.
Just don't make a religion out of it, ok?
Hear, hear! Great post and certainly something to follow up on. Good ro cite Knuth also, literate programming needs more support as well.
Usually, when I read the code, I don't read it like a book - all the lines one after another, instead, I read it following the logic path I'm currently interested in, from one logical block to another logical block, and it doesn't matter whether it's a "happy path" or not (it's up to me to decide, depending on the task at hand). So, reading through if/else statements don't create any issues for me, I just look at the condition and immediately proceed to "if" or "else" body. But what frustrates me - is complex "if" conditions and early returns. They both make it more difficult to only read through the code you need while skipping through the parts which are irrelevant to your current goal. First, I have to use the extra time to process the "inverted condition" and then go through the whole function making sure there are no early returns that will unexpectedly interrupt the flow I'm currently interested in, so as a result - I have to read much more lines (basically, all of them) and put more effort to get through the code.
Long story short: I'm not convinced. I still think using if/else statements and a single return at the end of a function is better for readability and stability of the code. Besides, if you're still lacking the context, I assume, any modern IDE lets you just click on the closing parentheses of any statement to quickly remind you what was the "if" statement at the beginning of it.
Imagine someone rejecting a PR over an else statement.
I was not aware of it until I read your article: I use all the techniques you bring forward. So I have no other option than to agree 100% with your point of view on ELSE :)
To me it feels natural to invert the IF statements and exit early for example.
I love this. Was anyone else told or taught (many years ago maybe) that every function should only have a single return? That old rule contributed greatly to the requirement for multiple nested levels of if statements and the need for lots of else's. With that rule dumped, it's much easier to write more readable code as in this article. BTW not heard it called a 'happy path' before but that's a great way to describe it.
OK folks. Readability IS a sign of code quality - for sure. HOWEVER, that does not mean it is necessary to drop useful elements of any language. You can't assert "never use a knive!" simply because misuse of knives is dangerous and can be BLOODY.
It is interesting to note, how little the examples in this post are commented !
ALTERNATIVELY, consider focussing on more and proper commenting:
// Process the passed argument, ... the result of the ... calculation ... , ... if it is useful
if myVariable != nil {
//DoSomeUsefulStuff()
}
Now judge by yourself how well the else part reads if commented (of course with some context of the preceeding IF logic)
// Drop out of the function / procedure if the passed argument, ... the result of the ... calculation ... , ... is NOT useful
} else {
return “”
}
My personal summary on code readability: Do comment;
And in 2005 this article affirmed what you are saying using the Visitor pattern.
Hey, that's an interesting article. Thanks for sharing that.
Personally, I'm not convinced inheritance (and arguably over-abstraction) provides more readable code - but there is definitely something to be said for reframing the problem to remove any special cases.
"Hey Siri, how do I un-publish someone else's blog post from the Internet?"
I'm not agree with you.
Same weak argument can be applied to a lot of clause.
Hey, thanks for reading. Is there some area, in particular, where you feel my argument falls short? I'm struggling to think of other places you could apply the same argument.
Completely agree with this. I also prefer to write code this way and always suggest it to others as I find it produces a far simpler and more readable result.
the quote - is not by D.Knuth, it is Abelman & Sussman, SICP, preface. look it up
I fully agree.
This is part of our style guide; which all of our devs are expected to adhere to.