DEV Community

Heru Hartanto
Heru Hartanto

Posted on • Updated on

Clean your condition ๐Ÿงผ

Always positive

It's need extra effort to understanding logic in negative condition, avoid it as you can

// โŒ Don't 

function isUserNotVerified(){

}

if(!userVerified){

}

// โœ… Do

function isUserVerified(){

}

if(userVerified){

}

Enter fullscreen mode Exit fullscreen mode

Use Shorthands if possible

Shorthands make your code use less line and easier to read

// โŒ Don't

if(isActive ==null){

}

if(firstname !== null || firstname !=='' || firstname !== undefined){

}

const isUserValid = user.isVerified() && user.isActive() ? true : false;

// โœ… Do

if(isActive) {

}

if(!!firstname){

}

const isUserValid = user.isVerified() && user.isActive()
Enter fullscreen mode Exit fullscreen mode

Object literals over Switch statements

// โŒ Don't

const getStatus = (status) => {
  switch (status) {
    case "success":
      return "green";
    case "failure":
      return "red";
    case "warning":
      return "yellow";
    case "loading":
    default:
      return "blue";
  }
};

// โœ… Do
const statusColors = {
  success: "green",
  failure: "red",
  warning: "yellow",
  loading: "blue",
};

const getStatus = (status) => statusColors[status] || statusColors.loading;
Enter fullscreen mode Exit fullscreen mode

Use optional chaining

Remember that optional chaining is not working with IE browser yet, see here

const alice = {
    name:'Alice',
    cat:{
        name:'Nala'
    }
}
// โŒ Don't

const cat = (alice && alice.cat && alice.cat.name) || 'N/A';

// โœ… Do

const cat = alice?.cat?.name ?? 'N/A';

Enter fullscreen mode Exit fullscreen mode

Discussion (3)

Collapse
mikenatsu profile image
MikeNatsu

For shorthands like if(!!something), why cant we just do if (something)???

Collapse
elukuro profile image
Heru Hartanto Author

Yes you could, the only difference is !!something will return boolean

Collapse
jiko profile image
Jiko
const getStatus = (status = 'loading') => statusColors?.[status] ?? statusColors.loading;
Enter fullscreen mode Exit fullscreen mode