Thought I had replied, must have closed browser by mistake π
Looks like you are right, Line 223 in fastimages
@property = if @options[:animated_only] :animated elsif @options[:type_only] :type else :size end
So it looks to be animated, type or size as you thought.
Pretty sure you could extend it and just call them both together but that is probably an over optimisation!
Great solution for CLS either way ! β€
Iβd consider this an over optimization for the matter of this first PR, but once itβs merged, a dedicated task to optimize this makes sense.
Are you sure you want to hide this comment? It will become hidden in your post, but will still be visible via the comment's permalink.
Hide child comments as well
Confirm
For further actions, you may consider blocking this person and/or reporting abuse
We're a place where coders share, stay up-to-date and grow their careers.
Thought I had replied, must have closed browser by mistake π
Looks like you are right, Line 223 in fastimages
So it looks to be animated, type or size as you thought.
Pretty sure you could extend it and just call them both together but that is probably an over optimisation!
Great solution for CLS either way ! β€
Iβd consider this an over optimization for the matter of this first PR, but once itβs merged, a dedicated task to optimize this makes sense.