DEV Community

irenejoeunpark
irenejoeunpark

Posted on

2 1

My First Pull Request on Hacktoberfest 2021

As the first participation on hacktoberfest 2021, I chose an issue from search API called meilisearch. It was built for Java developers to help with their searches with some filters, sorting, and keywords which makes the developers to integrate search function easier in their program.

The issue was created by the modifier of the project,
https://github.com/meilisearch/meilisearch-java/issues/270
It was missing some test cases for the setting functions.
I had no experience with Junit before, but unit testing seemed very interesting and important so I chose to contribute to the issue.

The tasks are to create one more test case for each subsetting functions when user input null as the setting value. The function was to reset the setting to the default setting of the API.
Junit methods that was being used in my test cases are below.

assertEqual(expected,actual);
assertNotEqual(expected, actual);
assertArrayEqual(expected, actual);
Enter fullscreen mode Exit fullscreen mode

After I push my changes and create PR, I failed the automated test because I forgot to run the script to remove the linter.
And after I remove the linter, I was finally able to get it passed and accepted by the modifier.
https://github.com/meilisearch/meilisearch-java/pull/271

Speedy emails, satisfied customers

Postmark Image

Are delayed transactional emails costing you user satisfaction? Postmark delivers your emails almost instantly, keeping your customers happy and connected.

Sign up

Top comments (0)

Billboard image

The Next Generation Developer Platform

Coherence is the first Platform-as-a-Service you can control. Unlike "black-box" platforms that are opinionated about the infra you can deploy, Coherence is powered by CNC, the open-source IaC framework, which offers limitless customization.

Learn more

👋 Kindness is contagious

Please leave a ❤️ or a friendly comment on this post if you found it helpful!

Okay