My final goal for this week was to continue my participation for Seneca's open source repository's by Reviewing Pull requests. I participated in two different Pull requests
First Review
This was my first review I looked over the code and from what I tested it worked. Others however wanted their to be a new test to test the new feature.
Second Review
This was my second review again I looked over it and the code and the feature worked locally.
What did I learn
My way of testing was not enough I need to continue my practice and look deeper into the code to make sure everything works. But I also need more practice writing a valid review my simple looks good comment should be replaced with some constructive criticism and maybe include some things that I think they did well. I'm going to continue to practice but next time I'm going to make sure that when I review something i really look into and consider the ways that i would've done it to make it better or more efficient. From the amount of reviews I had in my telescope PR I knew that the amount their could always be something to improve on or change.
Top comments (0)