DEV Community 👩‍💻👨‍💻

Cover image for QuickTip: To Do CodeReview
Sujit Agarwal
Sujit Agarwal

Posted on

QuickTip: To Do CodeReview

Tips For Reviewers:

1. Be kind.
2. Explain yourself.
3. Focus on pointing out problems and let the developer decide.
4. Request the Dev for simplified code (if required) or code comments.

Things to look for during the review:

1. Code Design.
2. Expected Functionality v/s Outcome.
3. Code Complexity.
4. Tests done.
5. Code Comments.
6. Naming conventions.
7. Consistency with existing code.
8. Documentation.
9. Follows the team's principles.

The Joel Test:

The Joel Test is a very simple and quick test that rates the quality of your software team. Rather than including open-ended responses, this test has 12 yes-or-no questions that determine whether your programming team is up to par.

1. Do you use source control?
2. Can you make a build in one step?
3. Do you make daily builds?
4. Do you have a bug database?
5. Do you fix bugs before writing new code?
6. Do you have an up-to-date schedule?
7. Do you have a spec?
8. Do programmers have quiet working conditions?
9. Do you use the best tools money can buy?
10. Do you have testers?
11. Do new candidates write code during their interview?
12. Do you do hallway usability testing?

Read more about the Joel Test here.

Top comments (0)

🌙 Dark Mode?!

Turn it on in Settings