This was a busy week for me. I managed to get three PR's submitted all while having some extra meetings and deadlines show up for work. Not to mention getting this little two month old cutie on Saturday (Feb 12th) and dealing with everything that having a puppy entails.
Adding GITHUB_TOKEN to the environment
The first PR was actually one I submitted last week as a draft because I needed some help figuring out why my approach wasn't working. 
As you can see from the description in the PR, my wording shows I have my doubts about if it will work or not. I was really just taking educated guesses on everything and most of my assumptions ended up being correct. I only had to make a few minor adjustments and it was time to test.
I had no clue where to even begin testing to see if this was all working. Josue helped out a bunch with this/ he did all the testing while I watched in awe through screen-share. I knew he was a core contributor and an integral part of Telescope, and I got a glimpse as to just how important he is to the project.
In order to test it out Josue had to shut down the staging environment. Then configured the files to be like what I would be submitting in the PR. He had to do this because the PR would potentially delete things and not build them back properly if not working correctly. He then had to go into the settings of the Telescope repo and trigger the web hook to mimic a PR getting merged. That confirmed the GITHUB_TOKEN was indeed populating.
This PR was a very informative process. Not just for me either. 
Reducing the size of web service
The second PR was another one I started last week and had made a draft PR for because I needed some assistance. Once again it was Josue to the rescue.
After making those fixes I got the green light from the professor.
Just waiting on at least one more review before landing this one.
Dockerizing Docusaurus
The previous PR's I went over above either had no release attached to them, or was scheduled for 2.8. The only task I had for 2.7 was this one. Unfortunately I missed it being assigned to me last week and only noticed it on Monday. Started working on it Tuesday, and submitted yet another draft PR because of roadblocks I was hitting.
After submitting the PR, I noticed Cindy had started working on it a few hours later. She came across an issue when building it that she filed an issue for, then submitted a PR for. I reviewed the PR to help facilitate the assistance she was providing. 
After coming back to the issue the next night, it would seem Cindy and Dave have got it sorted out! 
Coming up next
There has been some issues that stemmed from some of the work I have done this week. I need to dig around the repo and find any Dockerfiles that I could slim down by doing what I did for my second PR of this week. I can then file issues and start submitting PR's for each one.
I also need to submit a PR in follow up of my first PR of the week. 
I had meant to actually make that simple change to the doc and amend the commit for that PR, but I was too eager to get it landed and start working on the Docusaurus issue.
Top comments (0)