loading...

Discussion on: Hacktoberfest Completion Thread

Collapse
thefern profile image
Fernando B πŸš€

As long as they are submitted they don't have to be accepted. As long as they are not reported as spam PRs, you're good.

Obviously we want our work to be merged. Last year one of my 4prs just sat there sadly, guess the maintainer abandoned the repo.

Collapse
sunilkrsingh profile image
Sunil Kumar Singh

If a maintainer marks the PR as invalid after the review period, will I get my T-shirt? Or will I need to more PRs?

Thread Thread
thefern profile image
Fernando B πŸš€

Not entirely sure about invalid PRs, but more likely not.

Thread Thread
sunilkrsingh profile image
Sunil Kumar Singh

Thanks for the kind reply. Was a bit over-excited I guess!

Thread Thread
clion profile image
C-Lion

You still have time to submit a few more if you need to! 4 is the minimum, not the maximum!

Collapse
timrodz profile image
Juan Alejandro Morais

Oh okay, thanks for explaining that Fernando!

I actually went ahead and made a few more PRs 😊 hopefully all of them will be merged πŸ•ΊπŸ½