Reviewing code is not really my strong suit. It takes a lot of time and effort, something I lack. But I knew it was an essential tool to programmers, taking in and considering better alternatives for code, as well as optimizing it. So I had to push through, and eventually I found several errors within my first review:
Review
My first ever code review, I decided to do within my-photohub. I reviewed a fellow students code that being SerpentBytes. I tried nitpicking at the small details.
After that, I then decided to clone his code locally via the use of the HTTPS cloning and I couldn't really find anything that caught my eye. So I decided to use ESlint for any syntax. ESLint found several, one of which was an Unused import.
After I submitted what I found the author of the pull request contacted me to help him test out the new version after he had made the changes. He walked me through getting my personal access tokens. It took a while because I did not have gh_ before my token name. Which then caused me to have an error 400 being that it was an invalid request.
So after getting that sorted out, when I added the proper credentials with an access token that does begin with gh_, I finally got a passing message 200. He then asked me to check my GitHub if a repository has been created or not. When I checked, a new repository had been created in my account.
He then asked me to re-input the access token so I did as he told. It was to check whether you can use the same access token twice. Tested it out, and a new repository had been created. So it was working completely as intended.
Thoughts
It was great to work collaboratively on these issues as an open source community. I learned a lot from reviewing other people's code, and it was interesting to see how everyone tried to approach similar tasks in different ways. Overall, I hope that these reviews will help to improve the code quality in the future.
Top comments (1)
What is Google's internal code review process? Spells to bring a lover back