Feruz Oripov, The Real MVP.

Refactoring organizations_controller.rb. #3793

FeruzOripov posted on Aug 22, 2019

Adding set_organization method for not repeating query code.

What type of PR is this? (check all applicable)

• [x] Refactor
• [ ] Feature
• [ ] Bug Fix
• [ ] Documentation Update

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

• [ ] docs.dev.to
• [ ] readme
• [ ] no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

View on GitHub

Refactoring dashboards_controller.rb. #3794

FeruzOripov posted on Aug 22, 2019

What type of PR is this? (check all applicable)

• [x] Refactor
• [ ] Feature
• [ ] Bug Fix
• [ ] Documentation Update

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

• [ ] docs.dev.to
• [ ] readme
• [x] no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

View on GitHub

Refactoring chat_channels_controller.rb. #3808

FeruzOripov posted on Aug 23, 2019

What type of PR is this? (check all applicable)

• [x] Refactor
• [ ] Feature
• [ ] Bug Fix
• [ ] Documentation Update

Description

Related Tickets & Documents

#3739

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

• [ ] docs.dev.to
• [ ] readme
• [x] no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

View on GitHub

Refactoring social_previews_controller.rb. #3818

FeruzOripov posted on Aug 24, 2019

What type of PR is this? (check all applicable)

• [x] Refactor
• [ ] Feature
• [ ] Bug Fix
• [ ] Documentation Update

Description

Refactoring repeated respond_to code.

Related Tickets & Documents

#3739

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

• [ ] docs.dev.to
• [ ] readme
• [x] no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

View on GitHub

Feruz OripovFollow

This is how great software happens.

Comments

[Yaser Al-Najjar]

Refactoring code is a great skill that not so many developers have...

Many developers feel afraid of doing these kind of tasks, it's actually scary cuz even changing one line could break things!

Great job, @feruzoripov ✋

[Theo]

I've always found refactoring to be refreshing ans even fun.
Thinking of better and more efficient ways to do something.

But thats just me. I always keep a copy of my original code just incase which helps me to not be afraid to royaly screw itup 😁.

[Yaser Al-Najjar]

I find it the opposite, cuz sometimes this happen:

[Ben Halpern]

Refactoring against a sturdy test suite is fun. Not so much without 😄

Therapeutic refactoring is definitely a thing

[Feruz Oripov]

This is how I started my open source contribution journey, thanks )

[Shannon Crabill]

Factoring is so important!

[rhymes]

Great job @feruzoripov!

[Feruz Oripov]

Thanks)

[Feruz Oripov]

I'm so inspired after reading it. Thank you so much )