DEV Community

Discussion on: What common programming concept has the wrong name?

Collapse
 
ianfabs profile image
Ian Fabs

I 100% agree, GitLab calls them Merge Requests which is more accurate

Collapse
 
mxoliver profile image
Oliver

Exactly! and you aren't really requesting to pull anything, if anything you are requesting to push something. Merge request sounds better but at the same time I've gotten so used to pull request even though it makes no sense

Thread Thread
 
ben profile image
Ben Halpern

I guess it’s a request that the other person pull, right? But either way, merge request 100% better.

Thread Thread
 
mxoliver profile image
Oliver

Oh truue, I didn't think about that. It's like a "hey i did a thing, can you please pull this into master?"

Thread Thread
 
ben profile image
Ben Halpern

Still totally weird. I had the same confusion when first introduced.

Thread Thread
 
fernandomaia profile image
Fernando Maia

I asked myself the same thing a while ago, and I found a good explanation on SO which links to a GitLab's article that debates about this topic.

Thread Thread
 
jsn1nj4 profile image
Elliot Derhay • Edited

Think GitHub's feature name comes from git request-pull. Both are completed by the receiver rather than the author, so it's kind of pulling, even though it's a merge still...

But git pull is also git fetch && git merge FETCH_HEAD, so who knows...?

I guess GitLab's name for it does make more sense for the resulting action though.

Thread Thread
 
jessekphillips profile image
Jesse Phillips

One should always remember, Github created this workflow idea for mainstream. I'm curious if request-pull actually came after github.

I don't have a memory of the early days, but I expect the merge feature was not in the initial UI, meaning you literally asked the person to run git pull on your branch i.e. fetch and merge.

Thread Thread
 
edwbuck profile image
Edwin Buck • Edited

From my estimation, pull-request came from the author imposing his viewpoint on others. He assumed that he would be in control of the upstream repository and named it as a hybrid of what it was to him and what he had to do with it.

A better approach is to consider the user's point of view.

Git is a mess of badly structured commands, but a useful tool. Look at mercurial of you want an example of git workflows with a better command line interface.

Thread Thread
 
jessekphillips profile image
Jesse Phillips

You'll need to help me on this one. What does hg call it?

mercurial-scm.org/wiki/ReviewWorkf...

"Create a "Pull request" on data in the repo"

Thread Thread
 
nathankc profile image
Nathan K. Campbell

Don't bother looking at Mercurial if you're a BitBucket user though:
bitbucket.org/blog/sunsetting-merc...