FINALLY MADE MY FIRST PR!!
BEHAVIOR-1K
issue#1845
Actually, I made my first pull request (PR) to communicate with the PR reviewer of the project. It took me about 2 days to setup/install the program and learn the code to fully understand the issue. I've found the pinpoint of issue and came up with couple solutions.
Since this is my first time..
Look, everyone is scared of mistakes and based on my experience, crystal clear communication is the golden key. I just wanted to talk to the reviewer before I take any further action and I think I made a right decision.
Do you need this line of code?
One thing I realized is that when I make some changes on the code, there always is a line that looks like it contains some intention/opinion from the original writer. The problem is, to apply my changes, I have to remove that line of code. For example, a function return false if it identifies anything other then true in the list. If that is the case, why does it have assert all(...), "child_values has NoneTypes" line looking for Nonetype values? To solve this matter, instead of making a foggy assumption, I created a PR with [WIP] tag to communicate with the reviewer. I hope I can get some feedback about my approach to the issue.
Let's see what happens now.
Top comments (0)